You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/04/23 22:57:10 UTC

Review Request: Added a ZooKeeper "leader detector" abstraction.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4848/
-----------------------------------------------------------

Review request for mesos, John Sirois and Vinod Kone.


Summary
-------

See summary.


Diffs
-----

  src/Makefile.am 5b5f4a6 
  src/tests/zookeeper_tests.cpp a852103 
  src/zookeeper/detector.hpp PRE-CREATION 
  src/zookeeper/detector.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/4848/diff


Testing
-------

make check


Thanks,

Benjamin

Re: Review Request: Added a ZooKeeper "leader detector" abstraction.

Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4848/#review7183
-----------------------------------------------------------

Ship it!



src/zookeeper/detector.hpp
<https://reviews.apache.org/r/4848/#comment15848>

    Does difference mean memeber id set diff or id + data diff -> document it.



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment15849>

    I think you can eliminate the Option midlleman here.
    Can you also factor out a helper? - this same code is in the destructor above.


- John


On 2012-04-23 20:57:10, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4848/
> -----------------------------------------------------------
> 
> (Updated 2012-04-23 20:57:10)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5b5f4a6 
>   src/tests/zookeeper_tests.cpp a852103 
>   src/zookeeper/detector.hpp PRE-CREATION 
>   src/zookeeper/detector.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4848/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>

Re: Review Request: Added a ZooKeeper "leader detector" abstraction.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4848/#review7251
-----------------------------------------------------------

Ship it!



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16025>

    is 'self' already used by process?



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16022>

    s/has/have/ ?



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16023>

    whoaaaaah



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16024>

    what's happening here? comments would be helpful here.



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16026>

    i'm missing something. if u set the promise and immediately delete it, what gives?



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16028>

    though its clear, comments here and for the elseif would be clearer.



src/zookeeper/detector.cpp
<https://reviews.apache.org/r/4848/#comment16029>

    Why can't LeaderDetector itself be a libprocess instead of this indirection?


- Vinod


On 2012-04-23 20:57:10, Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4848/
> -----------------------------------------------------------
> 
> (Updated 2012-04-23 20:57:10)
> 
> 
> Review request for mesos, John Sirois and Vinod Kone.
> 
> 
> Summary
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 5b5f4a6 
>   src/tests/zookeeper_tests.cpp a852103 
>   src/zookeeper/detector.hpp PRE-CREATION 
>   src/zookeeper/detector.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4848/diff
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin
> 
>