You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/07 11:47:42 UTC
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1474: Revert "HIVE-23725: ValidTxnManager snapshot outdating causing partia…
kgyrtkirk commented on a change in pull request #1474:
URL: https://github.com/apache/hive/pull/1474#discussion_r484381500
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/reexec/ReExecutionDagSubmitPlugin.java
##########
@@ -76,7 +76,7 @@ public void beforeExecute(int executionIndex, boolean explainReOptimization) {
}
@Override
- public boolean shouldReExecute(int executionNum, CommandProcessorException ex) {
+ public boolean shouldReExecute(int executionNum) {
return (executionNum < maxExecutions) && retryPossible;
Review comment:
please change this to `retryPossible` ( and remove maxExecutions field)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org