You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaka11chen (via GitHub)" <gi...@apache.org> on 2024/06/17 13:02:18 UTC
[PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
kaka11chen opened a new pull request, #36417:
URL: https://github.com/apache/doris/pull/36417
## Proposed changes
[Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173421412
<details>
<summary>TPC-H: <b>Total hot run time: 40207 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 654227602665a04f3b659a148f9c0b00bf1b2b51, data reload: false
------ Round 1 ----------------------------------
q1 17893 4399 4301 4301
q2 2025 197 190 190
q3 10444 1169 1121 1121
q4 11402 845 820 820
q5 7671 2687 2676 2676
q6 225 142 139 139
q7 970 644 629 629
q8 9305 2112 2091 2091
q9 10407 6533 6600 6533
q10 9201 3936 3790 3790
q11 466 240 251 240
q12 704 252 247 247
q13 20380 3041 3026 3026
q14 266 231 219 219
q15 515 479 489 479
q16 692 389 381 381
q17 970 683 662 662
q18 8018 7445 7359 7359
q19 6563 1436 1542 1436
q20 655 318 334 318
q21 4866 3221 3874 3221
q22 397 337 329 329
Total cold run time: 124035 ms
Total hot run time: 40207 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4418 4226 4392 4226
q2 391 259 268 259
q3 3165 2901 2927 2901
q4 2013 1724 1701 1701
q5 5421 5501 5518 5501
q6 227 132 128 128
q7 2190 1852 1897 1852
q8 3286 3435 3407 3407
q9 8740 8747 8680 8680
q10 3879 3867 3814 3814
q11 583 492 501 492
q12 821 634 644 634
q13 15990 3183 3188 3183
q14 303 287 285 285
q15 546 464 490 464
q16 485 432 437 432
q17 1850 1507 1490 1490
q18 8163 7947 7705 7705
q19 1845 1564 1531 1531
q20 2999 1855 1897 1855
q21 5193 4684 4933 4684
q22 729 572 576 572
Total cold run time: 73237 ms
Total hot run time: 55796 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173407768
TeamCity be ut coverage result:
Function Coverage: 36.48% (9002/24679)
Line Coverage: 28.01% (73728/263203)
Region Coverage: 27.48% (38289/139333)
Branch Coverage: 24.17% (19515/80730)
Coverage Report: http://coverage.selectdb-in.cc/coverage/654227602665a04f3b659a148f9c0b00bf1b2b51_654227602665a04f3b659a148f9c0b00bf1b2b51/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173457989
<details>
<summary>ClickBench: <b>Total hot run time: 30.53 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 654227602665a04f3b659a148f9c0b00bf1b2b51, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.06 0.06
query4 1.66 0.08 0.10
query5 0.53 0.49 0.50
query6 1.13 0.73 0.73
query7 0.02 0.01 0.01
query8 0.04 0.04 0.04
query9 0.54 0.48 0.49
query10 0.54 0.55 0.52
query11 0.15 0.12 0.11
query12 0.15 0.12 0.12
query13 0.59 0.59 0.62
query14 0.79 0.80 0.77
query15 0.82 0.82 0.79
query16 0.37 0.38 0.37
query17 1.04 1.00 0.97
query18 0.23 0.26 0.24
query19 1.81 1.75 1.72
query20 0.02 0.01 0.01
query21 15.44 0.65 0.65
query22 3.41 8.13 2.07
query23 18.31 1.28 1.22
query24 2.21 0.21 0.21
query25 0.16 0.09 0.08
query26 0.26 0.18 0.17
query27 0.07 0.09 0.08
query28 13.16 1.01 1.00
query29 12.59 3.29 3.24
query30 0.26 0.08 0.06
query31 2.83 0.40 0.38
query32 3.26 0.46 0.46
query33 2.87 2.85 2.89
query34 17.33 4.39 4.45
query35 4.47 4.47 4.55
query36 0.65 0.48 0.45
query37 0.19 0.15 0.15
query38 0.15 0.14 0.15
query39 0.04 0.04 0.03
query40 0.17 0.14 0.13
query41 0.09 0.05 0.05
query42 0.06 0.05 0.04
query43 0.04 0.04 0.04
Total cold run time: 108.8 s
Total hot run time: 30.53 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173343238
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "kaka11chen (via GitHub)" <gi...@apache.org>.
kaka11chen commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173343481
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173687681
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173445754
<details>
<summary>TPC-DS: <b>Total hot run time: 173050 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 654227602665a04f3b659a148f9c0b00bf1b2b51, data reload: false
query1 931 388 372 372
query2 6387 2446 2287 2287
query3 6630 214 208 208
query4 18725 17330 17393 17330
query5 3616 476 479 476
query6 236 159 172 159
query7 4590 294 291 291
query8 322 290 289 289
query9 8549 2396 2381 2381
query10 602 302 275 275
query11 10595 10126 10037 10037
query12 119 86 82 82
query13 1638 357 375 357
query14 9489 6205 7707 6205
query15 227 190 189 189
query16 7792 263 257 257
query17 1922 544 526 526
query18 1956 269 273 269
query19 198 153 153 153
query20 90 102 83 83
query21 204 131 124 124
query22 4508 4234 4189 4189
query23 33738 33495 33524 33495
query24 10629 2942 2899 2899
query25 606 390 381 381
query26 721 161 164 161
query27 2303 328 340 328
query28 6050 2124 2107 2107
query29 918 650 647 647
query30 252 166 155 155
query31 966 789 782 782
query32 99 55 56 55
query33 699 292 279 279
query34 888 527 483 483
query35 745 629 621 621
query36 1136 985 965 965
query37 132 74 72 72
query38 2899 2814 2823 2814
query39 919 880 819 819
query40 212 125 132 125
query41 58 54 53 53
query42 133 109 106 106
query43 586 555 553 553
query44 1123 761 729 729
query45 193 161 157 157
query46 1078 789 759 759
query47 1849 1774 1766 1766
query48 376 297 292 292
query49 828 409 412 409
query50 775 395 391 391
query51 6704 6627 6697 6627
query52 102 92 96 92
query53 354 299 294 294
query54 857 445 434 434
query55 73 75 73 73
query56 274 251 259 251
query57 1175 1051 1048 1048
query58 267 243 247 243
query59 3447 3066 3099 3066
query60 310 278 279 278
query61 100 108 125 108
query62 608 451 463 451
query63 323 299 293 293
query64 8690 2281 1764 1764
query65 3182 3072 3110 3072
query66 739 332 328 328
query67 15293 15047 14998 14998
query68 4472 532 530 530
query69 542 420 380 380
query70 1171 1131 1162 1131
query71 380 277 279 277
query72 6954 5446 5463 5446
query73 753 330 329 329
query74 5917 5539 5522 5522
query75 3346 2613 2640 2613
query76 2254 947 904 904
query77 464 302 297 297
query78 10255 9841 9688 9688
query79 2827 524 585 524
query80 1958 472 478 472
query81 581 219 223 219
query82 1455 100 100 100
query83 323 169 170 169
query84 265 82 89 82
query85 1332 284 274 274
query86 466 337 307 307
query87 3272 3097 3075 3075
query88 4216 2349 2336 2336
query89 486 390 393 390
query90 1743 194 189 189
query91 131 100 100 100
query92 58 48 50 48
query93 2516 492 500 492
query94 1137 190 187 187
query95 418 317 317 317
query96 627 263 264 263
query97 3232 3055 2995 2995
query98 228 202 196 196
query99 1238 840 836 836
Total cold run time: 267752 ms
Total hot run time: 173050 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173687777
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](multi-catalog) Add more error msgs for wrong data types in orc and parquet reader. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36417:
URL: https://github.com/apache/doris/pull/36417#issuecomment-2173355904
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org