You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/12/11 15:02:19 UTC
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 9:02 a.m.)
Review request for Ambari, dilli dorai, John Speidel, Robert Nettleton, and Tom Beerbower.
Changes
-------
Added stack-level kerberos descriptor that shows the hierarchy for the entire stack. Updated service-level descriptor to handl multiple sevices in one descriptor but to return the relelvant one (for example YARN's descriptor includes YARN and MAPREDUCE2)
Bugs: AMBARI-8247
https://issues.apache.org/jira/browse/AMBARI-8247
Repository: ambari
Description
-------
Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
ambari-server/src/main/resources/properties.json fe67de9
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/27871/diff/
Testing (updated)
-------
Ran all unit tests for ambari-server
Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:22 min
[INFO] Finished at: 2014-12-11T13:14:46+00:00
[INFO] Final Memory: 43M/503M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 12, 2014, 2:38 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java, line 158
> > <https://reviews.apache.org/r/27871/diff/3/?file=789277#file789277line158>
> >
> > Can KerberosServiceDesctiptor.fromFile() return null? If not, no need for the if check.
Yes... it is possible for `KerberosServiceDesctiptor.fromFile` to return `null`, but unlikly in this scenario.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64955
-----------------------------------------------------------
On Dec. 11, 2014, 9:03 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 9:03 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64955
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java
<https://reviews.apache.org/r/27871/#comment107792>
Since the file is being set and not the path, shouldn't the method name be setKerberosFile()
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
<https://reviews.apache.org/r/27871/#comment107793>
Can KerberosServiceDesctiptor.fromFile() return null? If not, no need for the if check.
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
<https://reviews.apache.org/r/27871/#comment107795>
javadoc
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java
<https://reviews.apache.org/r/27871/#comment107796>
no need for prefixing method with 'this'. Just use getServices()
- John Speidel
On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:03 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review65016
-----------------------------------------------------------
merged to trunk
- John Speidel
On Dec. 12, 2014, 9:49 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2014, 9:49 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java ae7dd28
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 6f6577a
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/
-----------------------------------------------------------
(Updated Dec. 12, 2014, 4:49 p.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
Bugs: AMBARI-8247
https://issues.apache.org/jira/browse/AMBARI-8247
Repository: ambari
Description
-------
Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java ae7dd28
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 6f6577a
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
ambari-server/src/main/resources/properties.json fe67de9
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/27871/diff/
Testing
-------
Ran all unit tests for ambari-server
Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:22 min
[INFO] Finished at: 2014-12-11T13:14:46+00:00
[INFO] Final Memory: 43M/503M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64961
-----------------------------------------------------------
I agree that we need to introduce new kerberos descriptor endpoints under stacks and services.
The current approach of inlining the descriptors into existing resources is only temporary to unblock the UI guys.
Prior to GA, the descriptor properties added in this patch will need to be replaced with the new resources and this change will need to be coordinated with the UI team.
- John Speidel
On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:03 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 11, 2014, 7:43 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/properties.json, lines 201-206
> > <https://reviews.apache.org/r/27871/diff/3/?file=789285#file789285line201>
> >
> > This composite kerberos_descriptor will carry considerable amount of data and Versions reource carry very minimal amount of information regarding stack version. It will be nice to move kerberos_descriptor from being under Versions resource to a parent resource of stack versions API.
We need to make `kerberos_descriptor` a resource and make it a sub-resource on a cluster and also service. There is a *TODO* mentioned in the code and I will crate a JIRA to do it.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64832
-----------------------------------------------------------
On Dec. 11, 2014, 9:03 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 9:03 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 11, 2014, 7:43 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/properties.json, lines 201-206
> > <https://reviews.apache.org/r/27871/diff/3/?file=789285#file789285line201>
> >
> > This composite kerberos_descriptor will carry considerable amount of data and Versions reource carry very minimal amount of information regarding stack version. It will be nice to move kerberos_descriptor from being under Versions resource to a parent resource of stack versions API.
>
> Robert Levas wrote:
> We need to make `kerberos_descriptor` a resource and make it a sub-resource on a cluster and also service. There is a *TODO* mentioned in the code and I will crate a JIRA to do it.
>
> Tom Beerbower wrote:
> Are you saying that in the future the descriptor will live as both a property and sub-resource?
Just a sub-resource... of a cluster resource and a stack resource. I want to (eventually) remove the current `kerberos_descriptor` propetry - it is obvously flawed.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64832
-----------------------------------------------------------
On Dec. 11, 2014, 9:03 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 9:03 a.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Dec. 12, 2014, 12:43 a.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/properties.json, lines 201-206
> > <https://reviews.apache.org/r/27871/diff/3/?file=789285#file789285line201>
> >
> > This composite kerberos_descriptor will carry considerable amount of data and Versions reource carry very minimal amount of information regarding stack version. It will be nice to move kerberos_descriptor from being under Versions resource to a parent resource of stack versions API.
>
> Robert Levas wrote:
> We need to make `kerberos_descriptor` a resource and make it a sub-resource on a cluster and also service. There is a *TODO* mentioned in the code and I will crate a JIRA to do it.
Are you saying that in the future the descriptor will live as both a property and sub-resource?
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64832
-----------------------------------------------------------
On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:03 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/#review64832
-----------------------------------------------------------
ambari-server/src/main/resources/properties.json
<https://reviews.apache.org/r/27871/#comment107620>
This composite kerberos_descriptor will carry considerable amount of data and Versions reource carry very minimal amount of information regarding stack version. It will be nice to move kerberos_descriptor from being under Versions resource to a parent resource of stack versions API.
- Jaimin Jetly
On Dec. 11, 2014, 2:03 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27871/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 2:03 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
>
>
> Bugs: AMBARI-8247
> https://issues.apache.org/jira/browse/AMBARI-8247
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
> ambari-server/src/main/resources/properties.json fe67de9
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
> ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/27871/diff/
>
>
> Testing
> -------
>
> Ran all unit tests for ambari-server
> Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:22 min
> [INFO] Finished at: 2014-12-11T13:14:46+00:00
> [INFO] Final Memory: 43M/503M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 27871: Provide a way to get service-specific
Kerberos descriptor via REST API
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27871/
-----------------------------------------------------------
(Updated Dec. 11, 2014, 9:03 a.m.)
Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Robert Nettleton, Tom Beerbower, and Yusaku Sako.
Bugs: AMBARI-8247
https://issues.apache.org/jira/browse/AMBARI-8247
Repository: ambari
Description
-------
Provide a way for a caller via the REST API to get information about a service's Kerberos descriptor. This information should probably be attached to a service resource response.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 60d4f9b
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java 2794c18
ambari-server/src/main/java/org/apache/ambari/server/controller/StackVersionResponse.java a338a12
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java 1296ba1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackVersionResourceProvider.java 8c9a139
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 843df0b
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java d025946
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 1e1e3a0
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 0fd8728
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 5224aaa
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java b99dcd6
ambari-server/src/main/resources/properties.json fe67de9
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 734f4b9
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java b6b7190
ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HDFS/kerberos.json PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/services/HDFS/metainfo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/27871/diff/
Testing
-------
Ran all unit tests for ambari-server
Tests run: 2416, Failures: 0, Errors: 0, Skipped: 22
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:22 min
[INFO] Finished at: 2014-12-11T13:14:46+00:00
[INFO] Final Memory: 43M/503M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas