You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/12/28 05:40:34 UTC

[GitHub] storm pull request #2480: STORM-2867: Add consumer lag metrics to KafkaSpout

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2480#discussion_r158899496
  
    --- Diff: pom.xml ---
    @@ -278,7 +278,7 @@
             <storm.kafka.artifact.id>kafka_2.10</storm.kafka.artifact.id>
     
             <!-- kafka version used by new storm-kafka-client spout code -->
    -        <storm.kafka.client.version>0.10.0.0</storm.kafka.client.version>
    +        <storm.kafka.client.version>0.11.0.2</storm.kafka.client.version>
    --- End diff --
    
    Actually we are "effectively" dropping support of Kafka 0.9.x while moving from Storm 1.0.x to 1.1.0, because critical bugs in storm-kafka-client are not ported back to 1.0.x version line. I think we should try to avoid doing it again, but not sure for the cases like this. (bump the version for utilizing new feature)
    
    Btw, if Kafka doesn't always guarantee forward compatibility, we may need to define support versions of Kafka (and others, if we could maintain) and maintain that.


---