[jira] [Commented] (SAMZA-1055) Disable broken tests in SamzaRest due to Jetty version upgrade

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15707253#comment-15707253 ] 

ASF GitHub Bot commented on SAMZA-1055:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/26

    SAMZA-1055: Disable broken tests in SamzaRest

    Disables a broken test in SamzaRest due to Jetty version upgrade in Samza. This is a temporary solution just to keep the build green on master. Longer term solution is to mock the Jetty objects properly through Mockito.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 15e6d0bf5a08248d62943b9e5e97d34f301073f2
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Date:   2016-11-30T02:05:23Z

    SAMZA-1055: Disable broken tests in SamzaRest

----


> Disable broken tests in SamzaRest due to Jetty version upgrade
> --------------------------------------------------------------
>
>                 Key: SAMZA-1055
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1055
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>
> There was an jetty version upgrade in Samza  from version 8 to 9 across all modules. This has broken a Test in SamzaRest module due to following reasons.
> a) In the recent Jetty API, the following public method present in the class org.eclipse.jetty.util.component.ContainerLifeCycle exposes an package private param(Managed). 
> `public boolean addBean(Object o, Managed managed)` . This however, causes mockito which uses reflection to create mock instances to fail during the mock creation in tests. More details about this can be found here : https://github.com/mockito/mockito/issues/233
> b) Jetty 9 api is backward incompatible with Jetty 8. Some of the methods in org.eclipse.jetty.server.Server class were made final, hence making these methods impossible to be mocked with Mockito. 
> Before the permanent solution is found and to keep the samza master build unbroken, this SamzaRest test will be disabled temporarily. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)