You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/29 10:05:02 UTC

[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #18657: add validate of creating view for broadcast table

tuichenchuxin commented on code in PR #18657:
URL: https://github.com/apache/shardingsphere/pull/18657#discussion_r909446098


##########
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/ddl/impl/ShardingCreateViewStatementValidator.java:
##########
@@ -111,4 +119,43 @@ private boolean hasDistinct(final SelectStatement selectStatement) {
     private boolean hasLimit(final SelectStatement selectStatement) {
         return SelectStatementHandler.getLimitSegment(selectStatement).isPresent();
     }
+    
+    private boolean isMultiRouteUnitWithoutRule(final ShardingRule shardingRule, final SimpleTableSegment view, final RouteContext routeContext) {

Review Comment:
   Sure. Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org