You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Joshua Samuel (JIRA)" <ji...@apache.org> on 2012/05/18 02:23:02 UTC
[jira] [Updated] (THRIFT-1159) THttpClient->Flush() issue
(connection thru proxy)
[ https://issues.apache.org/jira/browse/THRIFT-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joshua Samuel updated THRIFT-1159:
----------------------------------
Attachment: thrift-1325013-THttpClient.cs-for-1159.patch
Patch based on alex_gs's THttpClient.cs + default to system/config file default proxy, rather than NULL to allow app config file to set the proxy correctly.
> THttpClient->Flush() issue (connection thru proxy)
> --------------------------------------------------
>
> Key: THRIFT-1159
> URL: https://issues.apache.org/jira/browse/THRIFT-1159
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Environment: w2k sp4, .net2
> Reporter: alex_gs
> Assignee: Jake Farrell
> Priority: Minor
> Labels: thrift
> Attachments: THttpClient.cs, thrift-1325013-THttpClient.cs-for-1159.patch
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> *1)* Issue with *timeout* at the moment of call *THttpClient->Flush()* when I try to get data thru *proxy*.
> Prerequestites: clent(c# thrift) before proxy, we resource (in my case http://google.com)
> Code:
> {code:java}
> class Program {
> static void Main(string[] args) {
> Uri uri = new Uri("http://google.com");
> TTransport transport = new THttpClient(uri);
> transport.Flush();
> }
> }
> {code}
> At the moment of call the method *transport.Flush();* just goes to sleep forever (in my app).
> Issue is locates in the: file *Transport/THttpClient.cs -> method CreateRequest()*
> code:
> {code:java}
> connection.Proxy = null;
> {code}
> The lib should set state of proxy using some methods like to:
> use default proxy - property WebRequest.DefaultWebProxy from namespace System.Net
> add new property or methods with Proxy object
> probably use a method of declaring an attribute in C# - to write own custom attribute(s) for class THttpClient; it's be able manage state of object inside without usage of some xml config files
> *2)* *Timeout period* is not set by default.
> Actually timeout period set to *0*
> Code (file Transport/THttpClient.cs):
> {code:java}
> private int connectTimeout = 0;
> private int readTimeout = 0;
> {code}
> Need to set value of timeout by default like *15* seconds instead of infinite interval.
> *3)* *HttpWebRequest connection properties* sets by default
> Code (file Transport/THttpClient.cs -> method CreateRequest()):
> {code:java}
> connection.ContentType = "application/x-thrift";
> connection.Accept = "application/x-thrift";
> connection.UserAgent = "C#/THttpClient";
> connection.Method = "POST";
> connection.ProtocolVersion = HttpVersion.Version10;
> {code}
> But need to *have a way to configure* it options thru object or class attributes in client code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira