You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by je...@apache.org on 2013/09/30 20:23:44 UTC
js commit: [CB-4942] [BlackBerry10] deviceready is never fired - Fix
typo event.toLowerCase to type.type.toLowerCase - Added eventListener for
webworksReady to allow nativeReady to fire
Updated Branches:
refs/heads/master f0458b6cd -> 5ad41a7bb
[CB-4942] [BlackBerry10] deviceready is never fired
- Fix typo event.toLowerCase to type.type.toLowerCase
- Added eventListener for webworksReady to allow nativeReady to fire
Reviewed By: Jeffrey Heifetz <jh...@blackberry.com>
Tested By: Tracy Li <tl...@blackberry.com>
Project: http://git-wip-us.apache.org/repos/asf/cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-js/commit/5ad41a7b
Tree: http://git-wip-us.apache.org/repos/asf/cordova-js/tree/5ad41a7b
Diff: http://git-wip-us.apache.org/repos/asf/cordova-js/diff/5ad41a7b
Branch: refs/heads/master
Commit: 5ad41a7bbd36fdbe948e2310507e7bc52dcefbee
Parents: f0458b6
Author: Carlos Santana <cs...@gmail.com>
Authored: Fri Sep 27 21:38:53 2013 -0400
Committer: Jeffrey Heifetz <jh...@blackberry.com>
Committed: Mon Sep 30 14:22:41 2013 -0400
----------------------------------------------------------------------
lib/blackberry10/platform.js | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-js/blob/5ad41a7b/lib/blackberry10/platform.js
----------------------------------------------------------------------
diff --git a/lib/blackberry10/platform.js b/lib/blackberry10/platform.js
index 73a322f..99f1cb1 100644
--- a/lib/blackberry10/platform.js
+++ b/lib/blackberry10/platform.js
@@ -37,18 +37,25 @@ module.exports = {
addDocumentEventListener.apply(document, arguments);
//Trapping when users add listeners to the webworks ready event
//This way we can make sure not to fire the event before there is a listener
- if (event.toLowerCase() === 'webworksready') {
+ if (type.toLowerCase() === 'webworksready') {
listenerRegistered = true;
fireWebworksReadyEvent();
}
}
};
+ channel.onDOMContentLoaded.subscribe(function () {
+ document.addEventListener("webworksready", function () {
+ channel.onNativeReady.fire();
+ });
+ });
+
channel.onPluginsReady.subscribe(function () {
webworksReady = true;
fireWebworksReadyEvent();
});
+
//Only fire the webworks event when both webworks is ready and a listener is registered
function fireWebworksReadyEvent() {
var evt;
@@ -57,7 +64,6 @@ module.exports = {
evt = document.createEvent('Events');
evt.initEvent('webworksready', true, true);
document.dispatchEvent(evt);
- channel.onNativeReady.fire();
}
}