[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4632: Activation Persister Service

[GitBox <gi...@apache.org>]

chetanmeh commented on a change in pull request #4632: Activation Persister Service
URL: https://github.com/apache/openwhisk/pull/4632#discussion_r327421139
 
 

 ##########
 File path: common/scala/src/main/resources/reference.conf
 ##########
 @@ -82,3 +82,22 @@ dispatchers {
     throughput = 5
   }
 }
+
+whisk {
+  kafka-activation-store {
+    # Name of the Kafka topic for sending WhiskActivations
+    # Set to
+    # - `completed-others` - When LogDriverLogStore is used
+    # - `activations` - When other LogStore is used where logs are stored as part of activation result
+    activations-topic = "completed-others"
+
+    # Also send to database via ActivationStore. This mode can be used for initial
+    # trial runs where data is sent to both places
+    db = false
+
+    # Maximum request size. By default it uses the MAX_ACTIVATION_LIMIT as computed from
+    # `whisk.activation.payload`. Bump it to higher value if the activation result also
+    # includes the logs
+    # max-request-size = 2 MB
 
 Review comment:
   Yes thats possible. Probably I can add a programatic check in `KafkaActivationStore` where we pick the max and log a warning.  Purpose here is to ensure that no activation is rejected due to max payload size error as the fallback route to add to db is disabled

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services