You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/09/14 19:07:54 UTC

Re: Review Request 68549: Added pause and resume helpers to the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68549/#review208634
-----------------------------------------------------------


Ship it!




No need to mention my patch in the commit message.

- Meng Zhu


On Aug. 28, 2018, 12:45 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68549/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2018, 12:45 p.m.)
> 
> 
> Review request for mesos, Meng Zhu and Till Toenshoff.
> 
> 
> Bugs: MESOS-9187
>     https://issues.apache.org/jira/browse/MESOS-9187
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently these helpers are only used in the allocator
> tests to prevent event-driven allocations that triggered
> when adding frameworks and agents.
> 
> This is the same as Meng's patch in https://reviews.apache.org/r/68049/ with a compilation fix.
> 
> 
> Diffs
> -----
> 
>   include/mesos/allocator/allocator.hpp fadd4e8e32c9edca4fefa1cd5f8c8720188d3ca5 
>   src/master/allocator/mesos/allocator.hpp e65a9698ffe514b5f129417694190790712de508 
>   src/master/allocator/mesos/hierarchical.hpp e3adb5dbb968684f6f63477f56a6abf4f288c896 
>   src/tests/allocator.hpp 1d844464741b3f40890198e2503593c76de870df 
> 
> 
> Diff: https://reviews.apache.org/r/68549/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>