You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "koushiro (via GitHub)" <gi...@apache.org> on 2024/10/31 11:03:27 UTC
[PR] chore(core/layers): align info method of trait Access and trait LayeredAccess [opendal]
koushiro opened a new pull request, #5258:
URL: https://github.com/apache/opendal/pull/5258
# Which issue does this PR close?
No
# Rationale for this change
The `metadata` method of `LayeredAccess` and `info` method of `LayeredAccess` is misaligned.
we used to use `metadata` and changed it to `info`.
# What changes are included in this PR?
- rename `metadata` method of `trait LayeredAccess`:
`fn metadata(&self) -> Arc<AccessorInfo>` => `fn info(&self) -> Arc<AccessorInfo>`
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(core/layers): align `info` method of `trait Access` and `trait LayeredAccess` [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5258:
URL: https://github.com/apache/opendal/pull/5258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(core/layers): align info method of trait Access and trait LayeredAccess [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #5258:
URL: https://github.com/apache/opendal/pull/5258#issuecomment-2449604371
This is a breaking change, we will need to wait for https://github.com/apache/opendal/discussions/5257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org