You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/06 15:08:17 UTC
[GitHub] [spark] attilapiros opened a new pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
attilapiros opened a new pull request #33233:
URL: https://github.com/apache/spark/pull/33233
### What changes were proposed in this pull request?
Upgrading the kubernetes-client to 5.5.0
### Why are the changes needed?
There are [several bugfixes](https://github.com/fabric8io/kubernetes-client/releases/tag/v5.5.0) but the main reason is version 5.5.0 contains [Support HTTP operation retry with exponential backoff (for status code >= 500)](https://github.com/fabric8io/kubernetes-client/issues/3087).
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
By running the integration tests including `persistentVolume` tests:
```
./resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh \
--spark-tgz $TARBALL_TO_TEST --hadoop-profile $HADOOP_PROFILE --exclude-tags r --include-tags persistentVolume
...
[INFO] --- scalatest-maven-plugin:2.0.0:test (integration-test) @ spark-kubernetes-integration-tests_2.12 ---
Discovery starting.
Discovery completed in 413 milliseconds.
Run starting. Expected test count is: 26
KubernetesSuite:
- Run SparkPi with no resources
- Run SparkPi with a very long application name.
- Use SparkLauncher.NO_RESOURCE
- Run SparkPi with a master URL without a scheme.
- Run SparkPi with an argument.
- Run SparkPi with custom labels, annotations, and environment variables.
- All pods have the same service account by default
- Run extraJVMOptions check on driver
- Run SparkRemoteFileTest using a remote data file
- Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties
- Run SparkPi with env and mount secrets.
- Run PySpark on simple pi.py example
- Run PySpark to test a pyfiles example
- Run PySpark with memory customization
- Run in client mode.
- Start pod creation from template
- PVs with local storage
- Launcher client dependencies
- SPARK-33615: Launcher client archives
- SPARK-33748: Launcher python client respecting PYSPARK_PYTHON
- SPARK-33748: Launcher python client respecting spark.pyspark.python and spark.pyspark.driver.python
- Launcher python client dependencies using a zip file
- Test basic decommissioning
- Test basic decommissioning with shuffle cleanup
- Test decommissioning with dynamic allocation & shuffle cleanups
- Test decommissioning timeouts
Run completed in 18 minutes, 34 seconds.
Total number of tests run: 26
Suites: completed 2, aborted 0
Tests: succeeded 26, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874903753
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45219/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874928037
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45219/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874846896
**[Test build #140708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140708/testReport)** for PR 33233 at commit [`fb3054a`](https://github.com/apache/spark/commit/fb3054acb3562333f8c7dd3d60383f0fcdcd7190).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-875256559
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-875962008
For the following bug fix, could you make a backporting PR please, @attilapiros ?
> There are several bugfixes but the main reason is version 5.5.0 contains Support HTTP operation retry with exponential backoff (for status code >= 500).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874967919
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33233:
URL: https://github.com/apache/spark/pull/33233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-875701240
+1, late LGTM. Thanks, @attilapiros and @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-876340748
@dongjoon-hyun
Sure, which branches do you have in mind?
For the mentioned kubernetes-client feature we will need this one too: https://github.com/apache/spark/pull/33261
Otherwise only a few people will profit about having this available in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] attilapiros commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
attilapiros commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874860727
cc @dongjoon-hyun @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-878330254
If you think so, never mind, @attilapiros .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874959740
**[Test build #140708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140708/testReport)** for PR 33233 at commit [`fb3054a`](https://github.com/apache/spark/commit/fb3054acb3562333f8c7dd3d60383f0fcdcd7190).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874846896
**[Test build #140708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140708/testReport)** for PR 33233 at commit [`fb3054a`](https://github.com/apache/spark/commit/fb3054acb3562333f8c7dd3d60383f0fcdcd7190).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874928037
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45219/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874878292
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45219/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33233:
URL: https://github.com/apache/spark/pull/33233#issuecomment-874967919
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140708/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org