You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Andrew Pilloud (JIRA)" <ji...@apache.org> on 2019/04/19 16:29:00 UTC

[jira] [Comment Edited] (BEAM-7098) SQL module should not depend on Direct runner at shadow level

    [ https://issues.apache.org/jira/browse/BEAM-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822030#comment-16822030 ] 

Andrew Pilloud edited comment on BEAM-7098 at 4/19/19 4:28 PM:
---------------------------------------------------------------

These packages are poorly named. Here is what they actually contain:
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql]
 ** Core SQL Transform
 ** JDBC Driver
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql/jdbc]
 ** SQL Shell
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql/shell]
 ** Nothing, just a tool for building a jar

The JDBC Driver has hard dependencies on DirectOptions to call setBlockOnRun. I would guess it isn't too difficult to remove that.


was (Author: apilloud):
These packages are poorly named. Here is what they actually contain:
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql]
 ** Core SQL Transform
 ** JDBC Driver
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql/jdbc]
 ** SQL Shell
 - [https://github.com/apache/beam/tree/master/sdks/java/extensions/sql/shell]
 ** Nothing, just a tool for building a jar

The JDBC Driver has dependencies on DirectOptions to call setBlockOnRun. I would guess it isn't too difficult to remove that.

> SQL module should not depend on Direct runner at shadow level
> -------------------------------------------------------------
>
>                 Key: BEAM-7098
>                 URL: https://issues.apache.org/jira/browse/BEAM-7098
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Ismaël Mejía
>            Priority: Minor
>              Labels: triaged
>
> Today SQL runner depends on direct runner as a dependency probably to pack and run the CLI however this could be an issue because other runners may have dependency conflicts with it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)