[GitHub] Mister-Meeseeks commented on issue #23830: [SPARK-26935][SQL]Skip DataFrameReader's CSV first line scan when not used

[GitBox <gi...@apache.org>]

Mister-Meeseeks commented on issue #23830: [SPARK-26935][SQL]Skip DataFrameReader's CSV first line scan when not used
URL: https://github.com/apache/spark/pull/23830#issuecomment-466099210
 
 
   Added a comment explaining the downstream logic inside `DataFrameReader` I think it adequately documents the thought-process, and makes the PR ready to merge for now. 
   
   If you still think it's a good idea to address the underlying approach to how the CSV class complex coordinates the collection of the first line, I can make a new PR. Either with something like the `CSVHeaderBox` approach from the above comment, or any sort of alternative which you guys think might be better.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org