You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Alexander Shraer (JIRA)" <ji...@apache.org> on 2012/09/23 03:51:07 UTC
[jira] [Updated] (ZOOKEEPER-1539) Tests in QuorumUtil.startAll()
and JMXenv
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Shraer updated ZOOKEEPER-1539:
----------------------------------------
Description:
Consider the following test:
@Test
public void newTest() throws Exception {
QuorumUtil qu = new QuorumUtil(3);
qu.startAll();
}
Although it doesn't seem like we're checking anything at all here, this test actually fails. There is a JMXEnv.ensureAll test invoked from startAll(). It passes for QuorumUtil(1) or QuorumUtil(2) servers but fails for any larger number. Besides the fact that there's a bug in the tests, I think we should call the function differently if we want to invoke tests in it, or alternatively remove these tests or make them optional using some parameter.
was:
Consider the following test:
@Test
public void newTest() throws Exception {
QuorumUtil qu = new QuorumUtil(3);
qu.startAll();
}
Although it doesn't seem like we're checking anything at all here, this test actually fails. There is a JMXEnv.ensureAll test invoked from startAll(). It passes for 1 or 2 servers but fails for any larger number of servers (for example 3 servers here). Besides the fact that there's a bug in the tests, I think we should call the function differently if we want to invoke tests in it, or alternatively remove these tests or make them optional using some parameter.
> Tests in QuorumUtil.startAll() and JMXenv
> -----------------------------------------
>
> Key: ZOOKEEPER-1539
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1539
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Alexander Shraer
> Priority: Minor
>
> Consider the following test:
> @Test
> public void newTest() throws Exception {
> QuorumUtil qu = new QuorumUtil(3);
> qu.startAll();
> }
> Although it doesn't seem like we're checking anything at all here, this test actually fails. There is a JMXEnv.ensureAll test invoked from startAll(). It passes for QuorumUtil(1) or QuorumUtil(2) servers but fails for any larger number. Besides the fact that there's a bug in the tests, I think we should call the function differently if we want to invoke tests in it, or alternatively remove these tests or make them optional using some parameter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira