You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/01/08 18:29:23 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #2189: SOLR-14413 fix unit test to use delayed handler
madrob opened a new pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] slackhappy commented on pull request #2189: SOLR-14413 fix unit test to use delayed handler
Posted by GitBox <gi...@apache.org>.
slackhappy commented on pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#issuecomment-756956274
thanks for making these changes, certainly an improvement!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #2189: SOLR-14413 fix unit test to use delayed handler
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] slackhappy commented on a change in pull request #2189: SOLR-14413 fix unit test to use delayed handler
Posted by GitBox <gi...@apache.org>.
slackhappy commented on a change in pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#discussion_r554151852
##########
File path: solr/core/src/test/org/apache/solr/CursorPagingTest.java
##########
@@ -521,6 +522,7 @@ public void testTimeAllowed() throws Exception {
"fl", "id",
"sort", "id asc",
"rows", "50",
+ "qt", "/delayed",
Review comment:
ah! wasn't sure how to do this, `qt`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] slackhappy commented on a change in pull request #2189: SOLR-14413 fix unit test to use delayed handler
Posted by GitBox <gi...@apache.org>.
slackhappy commented on a change in pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#discussion_r554151852
##########
File path: solr/core/src/test/org/apache/solr/CursorPagingTest.java
##########
@@ -521,6 +522,7 @@ public void testTimeAllowed() throws Exception {
"fl", "id",
"sort", "id asc",
"rows", "50",
+ "qt", "/delayed",
Review comment:
ah! wasn't sure how to do this, `qt`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] slackhappy commented on pull request #2189: SOLR-14413 fix unit test to use delayed handler
Posted by GitBox <gi...@apache.org>.
slackhappy commented on pull request #2189:
URL: https://github.com/apache/lucene-solr/pull/2189#issuecomment-756956274
thanks for making these changes, certainly an improvement!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org