You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/06/23 23:01:44 UTC

[GitHub] [ignite] dmagda commented on a change in pull request #7936: IGNITE-13154 Introduce the ability for a user to manage binary types

dmagda commented on a change in pull request #7936:
URL: https://github.com/apache/ignite/pull/7936#discussion_r444554144



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryUtils.java
##########
@@ -1044,8 +1044,12 @@ public static BinaryMetadata mergeMetadata(@Nullable BinaryMetadata oldMeta, Bin
                             "Type '" + oldMeta.typeName() + "' with typeId " + oldMeta.typeId()
                                 + " has a different/incorrect type for field '" + newField.getKey()
                                 + "'. Expected '" + oldFieldTypeName + "' but '" + newFieldTypeName
-                                + "' was provided. Field type's modification is unsupported, clean {root_path}/marshaller " +
-                                "and {root_path}/db/binary_meta directories if the type change is required."
+                                + "' was provided. Field type's modification is unsupported, if the type change is " +

Review comment:
       Taras, how about this version of the message that suggests a workaround? (I think it's enough to suggest the control.sh approach only skipping the option that explains how to clean the metadata manually):
   
   _The type of an existing field can not be changed. Use a different field name or follow this procedure to reuse the current name: 
   * Delete data records that use the old field type.
   * Update the system metadata by running this command: 'control.sh/bat --meta remove --typeId oldMeta.typeId()'_ 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org