You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by liu-zhaokun <gi...@git.apache.org> on 2018/03/19 08:06:58 UTC

[GitHub] storm pull request #2599: [STORM-2996] Inaccurate description about offset a...

GitHub user liu-zhaokun opened a pull request:

    https://github.com/apache/storm/pull/2599

    [STORM-2996] Inaccurate description about offset and kafkaspout will make users confused

    [https://issues.apache.org/jira/browse/STORM-2996](https://issues.apache.org/jira/browse/STORM-2996)
    As you can see in the picture,we don't know which partition the offset belongs in first line,so I think we can log the partition information.And consumer.host is the same as host in Partition in second line,so I think we can remove it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liu-zhaokun/storm master0319

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2599.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2599
    
----
commit 9cab44a420b3d98c2b337900e703247748c7c7cf
Author: liuzhaokun <li...@...>
Date:   2018-03-19T07:55:16Z

    [STORM-2996] Inaccurate description about offset and kafkaspout will make users confused

----


---

[GitHub] storm issue #2599: [STORM-2996] Inaccurate description about offset and kafk...

Posted by liu-zhaokun <gi...@git.apache.org>.

Github user liu-zhaokun commented on the issue:

    https://github.com/apache/storm/pull/2599
  
    @HeartSaVioR 
    Could you help me review this PR?


---