You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2011/09/26 16:46:51 UTC

svn commit: r1175891 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/test/channel/ webapps/docs/

Author: markt
Date: Mon Sep 26 14:46:50 2011
New Revision: 1175891

URL: http://svn.apache.org/viewvc?rev=1175891&view=rev
Log:
Remove unused code

Modified:
    tomcat/tc7.0.x/trunk/   (props changed)
    tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
    tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java
    tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java
    tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Sep 26 14:46:50 2011
@@ -1 +1 @@
-/tomcat/trunk:1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256,1173288
 ,1173333,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175713
+/tomcat/trunk:1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096,1173241,1173256,1173288
 ,1173333,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175713,1175889

Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java?rev=1175891&r1=1175890&r2=1175891&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java (original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java Mon Sep 26 14:46:50 2011
@@ -49,9 +49,6 @@ public class TestDataIntegrity {
     private GroupChannel channel2;
     private Listener listener1;
 
-    @SuppressWarnings("unused")
-    private int threadCounter = 0;
-
     @Before
     public void setUp() throws Exception {
         channel1 = new GroupChannel();
@@ -85,8 +82,6 @@ public class TestDataIntegrity {
                     }catch ( Exception x ) {
                         x.printStackTrace();
                         return;
-                    } finally {
-                        threadCounter++;
                     }
                 }
             };
@@ -115,8 +110,6 @@ public class TestDataIntegrity {
                         }catch ( Exception x ) {
                             x.printStackTrace();
                             return;
-                        } finally {
-                            threadCounter++;
                         }
                     }
                 };

Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java?rev=1175891&r1=1175890&r2=1175891&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java (original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestMulticastPackages.java Mon Sep 26 14:46:50 2011
@@ -49,9 +49,6 @@ public class TestMulticastPackages {
     private GroupChannel channel2;
     private Listener listener1;
 
-    @SuppressWarnings("unused")
-    private int threadCounter = 0;
-
     @Before
     public void setUp() throws Exception {
         channel1 = new GroupChannel();
@@ -128,8 +125,6 @@ public class TestMulticastPackages {
                     }catch ( Exception x ) {
                         x.printStackTrace();
                         return;
-                    } finally {
-                        threadCounter++;
                     }
                 }
             };

Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java?rev=1175891&r1=1175890&r2=1175891&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java (original)
+++ tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestUdpPackages.java Mon Sep 26 14:46:50 2011
@@ -49,9 +49,6 @@ public class TestUdpPackages {
     private GroupChannel channel2;
     private Listener listener1;
 
-    @SuppressWarnings("unused")
-    private int threadCounter = 0;
-
     @Before
     public void setUp() throws Exception {
         channel1 = new GroupChannel();
@@ -120,8 +117,6 @@ public class TestUdpPackages {
                     }catch ( Exception x ) {
                         x.printStackTrace();
                         return;
-                    } finally {
-                        threadCounter++;
                     }
                 }
             };
@@ -171,8 +166,6 @@ public class TestUdpPackages {
                     }catch ( Exception x ) {
                         x.printStackTrace();
                         return;
-                    } finally {
-                        threadCounter++;
                     }
                 }
             };

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1175891&r1=1175890&r2=1175891&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Mon Sep 26 14:46:50 2011
@@ -262,6 +262,10 @@
         random number source for session ID generation to reduce the delays
         caused by waiting for entropy. (kkolinko/markt)
       </update>
+      <scode>
+        Code clean-up to further reduce the number of warnings reported by
+        Eclipse, FindBugs and CheckStyle. (markt/kkolinko)
+      </scode>
     </changelog>
   </subsection>  
 </section>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org