You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by max3163 <gi...@git.apache.org> on 2017/01/04 15:11:13 UTC
[GitHub] jmeter pull request #247: Checks for listener output file existence
GitHub user max3163 opened a pull request:
https://github.com/apache/jmeter/pull/247
Checks for listener output file existence
Before launch a test ( local or remote ) check existence of result file from all collectors listeners and ask to the user what he want to do :
- Don't start the test
- Append result to the file ( old default behaviour)
- replace the file
For non gui mode, a new param/option has been created ( i.e -f or --forceDeleteResultFile ) in order to replace all results files. If no option is indicated on the command line, the old behavior is retained
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/max3163/jmeter POW-305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit 36dd9f7ec959c69e06b7bf52f2ddb5866d822797
Author: Bruno Demion <mi...@apache.org>
Date: 2016-11-16T18:45:11Z
Tag for pre-release
git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC4@1770033 13f79535-47bb-0310-9956-ffa450edef68
commit 0b5b61f85c494dedd43ac1648bec96c92a6af33e
Author: Bruno Demion <mi...@apache.org>
Date: 2016-11-19T22:49:23Z
Vote succeeded, create the 3.1 tag
git-svn-id: https://svn.apache.org/repos/asf/jmeter/tags/v3_1@1770529 13f79535-47bb-0310-9956-ffa450edef68
commit faae298bc43b535fe9217d769dee6853f744e912
Author: Chassagneux Maxime <ma...@gmail.com>
Date: 2017-01-04T14:44:55Z
POW-305 Checks for listener output file existence
commit c2fd2b67d529940d9972ae523a857fa93609add1
Author: Chassagneux Maxime <ma...@gmail.com>
Date: 2017-01-04T14:59:29Z
Fix comment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/247
Merged with commit:
http://svn.apache.org/viewvc?rev=1783297&view=rev
This PR can be closed.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/247
Don't look the 331f476 commit, weird issue on my side, sry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #247: Checks for listener output file existence
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/247
Hi @max3163 ,
As you're a commiter now, could you apply it ?
I tried to but it seems the generated patch files contains other files (JSONManager) , I don't know why but there seem to be unrelated commits.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/247
I move and refactoring the code on the gui.action package. Where it's seem more logic.
What do you think about it Philippe ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/247
Hello,
I reviewed this PR and I have some blocker remarks so I didn't merge it:
- I think code in StandardJMeterEngine and DistributedRunner is duplicated
- I wouldn't put any dependency on java.awt in those 2 classes.
- deleteResultFile should not be static but I don't know how to make it better
Regards
Philippe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/247
I have fix all your remark :
- Refactoring code
- Move the popup in the gui.action package
- deleteResultFile is no more static and just in JMeter.java
This PR is now OK for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #247: Checks for listener output file existence
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/247
Hi Maxime,
Is the PR ok now ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---