You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2011/05/06 02:18:05 UTC

svn commit: r1100005 - /spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Author: mmartinec
Date: Fri May  6 00:18:05 2011
New Revision: 1100005

URL: http://svn.apache.org/viewvc?rev=1100005&view=rev
Log:
Bug 5491: MIME_QP_LONG_LINE triggering on valid email

Modified:
    spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Modified: spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
URL: http://svn.apache.org/viewvc/spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm?rev=1100005&r1=1100004&r2=1100005&view=diff
==============================================================================
--- spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm (original)
+++ spamassassin/branches/3.3/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm Fri May  6 00:18:05 2011
@@ -296,7 +296,16 @@ sub _check_attachments {
       }
 
       if ($where != 1 && $cte eq "quoted-printable" && ! /^SPAM: /) {
-        if (length > 77) {
+        # RFC 5322: Each line SHOULD be no more than 78 characters,
+        #           excluding the CRLF
+        # RFC 2045: The Quoted-Printable encoding REQUIRES that
+        #           encoded lines be no more than 76 characters long.
+        # Bug 5491: 6% of email classified as HAM by SA triggered the
+        #           MIME_QP_LONG_LINE rule. Apple Mail can generate a QP-line
+        #           that is 2 chars too long. Same goes for Outlook Web Access.
+        # lines include one trailing \n character
+      # if (length > 76+1) {  # conforms to RFC 5322 and RFC 2045
+        if (length > 78+1) {  # conforms to RFC 5322 only, not RFC 2045
 	  $pms->{mime_qp_long_line} = 1;
         }
         $qp_bytes += length;