You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "yahoNanJing (via GitHub)" <gi...@apache.org> on 2023/07/11 09:48:54 UTC

[GitHub] [arrow-datafusion] yahoNanJing opened a new pull request, #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

yahoNanJing opened a new pull request, #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #6910.
   
   # Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on code in PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#discussion_r1259511279


##########
datafusion/core/src/physical_plan/joins/hash_join_utils.rs:
##########
@@ -87,28 +87,77 @@ use datafusion_common::Result;
 // | 0 | 0 | 0 | 2 | 4 | <--- hash value 1 maps to 5,4,2 (which means indices values 4,3,1)
 // ---------------------
 
-// TODO: speed up collision checks
-// https://github.com/apache/arrow-datafusion/issues/50
+const MIN_JOIN_HASH_MAP_LEN: usize = 1024;
+
 pub struct JoinHashMap {
-    // Stores hash value to first index
-    pub map: RawTable<(u64, u64)>,
+    // Stores the first index for a bucket
+    buckets: Vec<u64>,
     // Stores indices in chained list data structure
     pub next: Vec<u64>,
+    // Stores the bucket mask for quickly finding a bucket for a hash value
+    bucket_mask: usize,
 }
 
-/// SymmetricJoinHashMap is similar to JoinHashMap, except that it stores the indices inline, allowing it to mutate
-/// and shrink the indices.
-pub struct SymmetricJoinHashMap(pub RawTable<(u64, SmallVec<[u64; 1]>)>);
-
 impl JoinHashMap {
     pub(crate) fn with_capacity(capacity: usize) -> Self {
+        let mut bucket_capacity = capacity.next_power_of_two();
+        if bucket_capacity < MIN_JOIN_HASH_MAP_LEN {
+            bucket_capacity = MIN_JOIN_HASH_MAP_LEN;
+        }
+        let bucket_mask = bucket_capacity - 1;
         JoinHashMap {
-            map: RawTable::with_capacity(capacity),
+            buckets: vec![0; bucket_capacity],
             next: vec![0; capacity],
+            bucket_mask,
         }
     }
+
+    /// Only used for testing
+    pub(crate) fn with_bucket_capacity(bucket_capacity: usize, capacity: usize) -> Self {
+        assert!(bucket_capacity > 0);
+        let bucket_capacity = bucket_capacity.next_power_of_two();
+        let bucket_mask = bucket_capacity - 1;
+        JoinHashMap {
+            buckets: vec![0; bucket_capacity],
+            next: vec![0; capacity],
+            bucket_mask,
+        }
+    }
+
+    #[inline]
+    pub(crate) fn insert(&mut self, hash_value: u64, index: usize) {
+        let bucket_index = self.bucket_mask & (hash_value as usize);
+        // We are sure the `bucket_index` is legal
+        unsafe {
+            let index_ref = self.buckets.get_unchecked_mut(bucket_index);
+            let prev_index = *index_ref;
+            // chained list at index is already initialized with 0
+            // 0 meaning end of list
+            *index_ref = index as u64 + 1;
+            if prev_index != 0 {
+                // Update chained Vec at index with previous value
+                self.next[index] = prev_index;
+            }
+        }
+    }
+
+    #[inline]
+    pub(crate) fn get_first_index(&self, hash_value: u64) -> u64 {
+        let bucket_index = self.bucket_mask & (hash_value as usize);
+        unsafe { *self.buckets.get_unchecked(bucket_index) }
+    }
 }
 
+impl fmt::Debug for JoinHashMap {

Review Comment:
   Is this needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630618489

   Last version:
   
   ```
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
   ┃ Query        ┃     main ┃ issue-6910-2 ┃       Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
   │ QQuery 1     │ 188.49ms │     186.08ms │    no change │
   │ QQuery 2     │  59.09ms │      67.80ms │ 1.15x slower │
   │ QQuery 3     │  50.46ms │      68.36ms │ 1.35x slower │
   │ QQuery 4     │  37.68ms │      42.58ms │ 1.13x slower │
   │ QQuery 5     │  93.91ms │     134.90ms │ 1.44x slower │
   │ QQuery 6     │  10.32ms │      10.63ms │    no change │
   │ QQuery 7     │ 195.52ms │     263.67ms │ 1.35x slower │
   │ QQuery 8     │  71.23ms │      94.81ms │ 1.33x slower │
   │ QQuery 9     │ 139.60ms │     180.05ms │ 1.29x slower │
   │ QQuery 10    │  97.05ms │     103.32ms │ 1.06x slower │
   │ QQuery 11    │  48.91ms │      50.65ms │    no change │
   │ QQuery 12    │  67.75ms │      73.31ms │ 1.08x slower │
   │ QQuery 13    │ 178.68ms │     191.45ms │ 1.07x slower │
   │ QQuery 14    │  11.94ms │      13.21ms │ 1.11x slower │
   │ QQuery 15    │  22.51ms │      24.32ms │ 1.08x slower │
   │ QQuery 16    │  50.32ms │      50.80ms │    no change │
   │ QQuery 17    │ 664.73ms │     669.85ms │    no change │
   │ QQuery 18    │ 516.12ms │     587.09ms │ 1.14x slower │
   │ QQuery 19    │  57.57ms │      57.99ms │    no change │
   │ QQuery 20    │ 203.75ms │     197.04ms │    no change │
   │ QQuery 21    │ 259.05ms │     331.78ms │ 1.28x slower │
   │ QQuery 22    │  28.06ms │      34.91ms │ 1.24x slower │
   └──────────────┴──────────┴──────────────┴──────────────┘
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631472088

   Btw, I propose to set the partition to be 1 for benchmark purpose due to:
   - Then it will be helpful to focus on the code logic rather than the task scheduling or thread model
   - Then it will be more fair to compare with other engines with single thread


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630650037

   FYI @sunchao who I believe is working on something similar. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631478476

   > > The building phase is a bit faster at the expense
   > 
   > Intuitively, I think the Vec is much simpler than the RawTable and the mask operation should be very efficient. And I don't know why the result seems not so good 😭
   
   Sorry, hit enter too soon, I updated my comment with my full thoughts on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630541307

   FYI, I had a branch where I got a bit better results with a similar approach (but still mixed): https://github.com/apache/arrow-datafusion/tree/bucketing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631479231

   > I think we might first have to see if we can further improve the collision checking (currently eq + filter + take) in order for this approach to become faster in general.
   
   You are right. I will continue to investigate on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on code in PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#discussion_r1259506459


##########
datafusion/core/src/physical_plan/joins/hash_join_utils.rs:
##########
@@ -87,28 +87,77 @@ use datafusion_common::Result;
 // | 0 | 0 | 0 | 2 | 4 | <--- hash value 1 maps to 5,4,2 (which means indices values 4,3,1)
 // ---------------------
 
-// TODO: speed up collision checks
-// https://github.com/apache/arrow-datafusion/issues/50
+const MIN_JOIN_HASH_MAP_LEN: usize = 1024;
+
 pub struct JoinHashMap {
-    // Stores hash value to first index
-    pub map: RawTable<(u64, u64)>,
+    // Stores the first index for a bucket
+    buckets: Vec<u64>,
     // Stores indices in chained list data structure
     pub next: Vec<u64>,
+    // Stores the bucket mask for quickly finding a bucket for a hash value
+    bucket_mask: usize,
 }
 
-/// SymmetricJoinHashMap is similar to JoinHashMap, except that it stores the indices inline, allowing it to mutate
-/// and shrink the indices.
-pub struct SymmetricJoinHashMap(pub RawTable<(u64, SmallVec<[u64; 1]>)>);
-
 impl JoinHashMap {
     pub(crate) fn with_capacity(capacity: usize) -> Self {
+        let mut bucket_capacity = capacity.next_power_of_two();
+        if bucket_capacity < MIN_JOIN_HASH_MAP_LEN {
+            bucket_capacity = MIN_JOIN_HASH_MAP_LEN;
+        }
+        let bucket_mask = bucket_capacity - 1;
         JoinHashMap {
-            map: RawTable::with_capacity(capacity),
+            buckets: vec![0; bucket_capacity],
             next: vec![0; capacity],
+            bucket_mask,
         }
     }
+
+    /// Only used for testing
+    pub(crate) fn with_bucket_capacity(bucket_capacity: usize, capacity: usize) -> Self {
+        assert!(bucket_capacity > 0);
+        let bucket_capacity = bucket_capacity.next_power_of_two();
+        let bucket_mask = bucket_capacity - 1;
+        JoinHashMap {
+            buckets: vec![0; bucket_capacity],
+            next: vec![0; capacity],
+            bucket_mask,
+        }
+    }
+
+    #[inline]
+    pub(crate) fn insert(&mut self, hash_value: u64, index: usize) {
+        let bucket_index = self.bucket_mask & (hash_value as usize);
+        // We are sure the `bucket_index` is legal
+        unsafe {
+            let index_ref = self.buckets.get_unchecked_mut(bucket_index);

Review Comment:
   I think we can limit the unsafe to:
   ```suggestion
               let index_ref = unsafe {self.buckets.get_unchecked_mut(bucket_index); }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630538664

   Thanks @yahoNanJing .  These are my results on this PR (`./bench.sh run tpch_mem`):
   
   ```
   Comparing main and issue-6910
   --------------------
   Benchmark tpch_mem.json
   --------------------
   ┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
   ┃ Query        ┃     main ┃ issue-6910 ┃       Change ┃
   ┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
   │ QQuery 1     │ 188.49ms │   187.15ms │    no change │
   │ QQuery 2     │  59.09ms │    68.42ms │ 1.16x slower │
   │ QQuery 3     │  50.46ms │    68.99ms │ 1.37x slower │
   │ QQuery 4     │  37.68ms │    51.33ms │ 1.36x slower │
   │ QQuery 5     │  93.91ms │   127.29ms │ 1.36x slower │
   │ QQuery 6     │  10.32ms │    10.48ms │    no change │
   │ QQuery 7     │ 195.52ms │   281.34ms │ 1.44x slower │
   │ QQuery 8     │  71.23ms │    93.99ms │ 1.32x slower │
   │ QQuery 9     │ 139.60ms │   181.29ms │ 1.30x slower │
   │ QQuery 10    │  97.05ms │   105.19ms │ 1.08x slower │
   │ QQuery 11    │  48.91ms │    49.58ms │    no change │
   │ QQuery 12    │  67.75ms │    79.33ms │ 1.17x slower │
   │ QQuery 13    │ 178.68ms │   188.84ms │ 1.06x slower │
   │ QQuery 14    │  11.94ms │    13.19ms │ 1.10x slower │
   │ QQuery 15    │  22.51ms │    23.93ms │ 1.06x slower │
   │ QQuery 16    │  50.32ms │    50.59ms │    no change │
   │ QQuery 17    │ 664.73ms │   657.27ms │    no change │
   │ QQuery 18    │ 516.12ms │   590.70ms │ 1.14x slower │
   │ QQuery 19    │  57.57ms │    58.17ms │    no change │
   │ QQuery 20    │ 203.75ms │   196.01ms │    no change │
   │ QQuery 21    │ 259.05ms │   356.25ms │ 1.38x slower │
   │ QQuery 22    │  28.06ms │    34.84ms │ 1.24x slower │
   └──────────────┴──────────┴────────────┴──────────────┘
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1632298280

   The main blocking issue for q17 is the join order and the decision making of choosing which part to be the build side.
   
   I think we can close this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631467115

   When using the bench tool on my PC with only one partition, the result is as follows:
   <img width="789" alt="Screenshot 2023-07-12 at 04 25 29" src="https://github.com/apache/arrow-datafusion/assets/90197956/0d768928-5b08-44e4-9227-57dc6ea050dc">
   
   The performance comparison between RawTable and (Vec and mask) may depend on the data size to be dealt with.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631471609

   My explanation so far:
   
   The building phase is a bit faster at the expense 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630582070

   Hi @Dandandan, could you help run the latest code of this PR on your PC for benchmark again? Btw, on my PC, I'm testing on TPCH 1G. 
   
   And could you help describe the CPU cache sizes? Mine is 
   ![Screenshot 2023-07-11 at 18 34 56](https://github.com/apache/arrow-datafusion/assets/90197956/33cb8f35-233f-4740-9737-8395d4244dcd)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] Dandandan commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630597595

   Sure @yahoNanJing 
   
   - Apple M1 Pro:
   <img width="675" alt="image" src="https://github.com/apache/arrow-datafusion/assets/163737/e84fb703-682a-4023-a540-eeb4599ebf63">
   
   - you can run the benchmark in `benchmarks/bench.sh`. You can generate the data using `./bench.sh data` and then run `./bench.sh run tpch_mem`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1630651314

   > you can run the benchmark in benchmarks/bench.sh. You can generate the data using ./bench.sh data and then run ./bench.sh run tpch_mem. Comparison against main can be done by running the benchmark on the main branch once as well and then running ./bench.sh compare main my-branch
   
   Thanks for providing this useful benchmark tool. I'll try it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing commented on PR #6913:
URL: https://github.com/apache/arrow-datafusion/pull/6913#issuecomment-1631477260

   > The building phase is a bit faster at the expense
   
   Intuitively, I think the Vec is much simpler than the RawTable and the mask operation should be very efficient. And I don't know why the result seems not so good 😭 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] yahoNanJing closed pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap

Posted by "yahoNanJing (via GitHub)" <gi...@apache.org>.
yahoNanJing closed pull request #6913: Improve the hash join performance by replacing the RawTable to a simple Vec for JoinHashMap
URL: https://github.com/apache/arrow-datafusion/pull/6913


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org