[GitHub] [spark] hvanhovell commented on a diff in pull request #42478: [SPARK-44795][CONNECT] CodeGenerator Cache should be classloader specific

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #42478:
URL: https://github.com/apache/spark/pull/42478#discussion_r1294098016


##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/OuterScopes.scala:
##########
@@ -26,28 +26,9 @@ import org.apache.spark.util.SparkClassUtils
 
 object OuterScopes {
   private[this] val queue = new ReferenceQueue[AnyRef]
-  private class HashableWeakReference(v: AnyRef) extends WeakReference[AnyRef](v, queue) {

Review Comment:
   It was a bit weird to use it as part of the OuterScopes object in a different class since the class - conceptually - itself has very little to do with OuterScopes. The other reason was the I didn't want the other refs to pollute the reference queue we are using here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org