You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by marekchen <gi...@git.apache.org> on 2018/03/06 07:07:45 UTC
[GitHub] incubator-weex pull request #1048: fix input bug
GitHub user marekchen opened a pull request:
https://github.com/apache/incubator-weex/pull/1048
fix input bug
英文不好就用中文描述了：
1.当在created中设置input的value值为“1”，然后删除“1”，这时不会触发input事件
2.当输入“1”后，还是不能触发input事件，因为value值和输入值相同时，不触发input事件
重现代码如下：
``` html
<template>
<div>
<div>
<text style="font-size: 40px">oninput: {{idCard}}</text>
<text style="font-size: 40px">onchange: {{idCard}}</text>
</div>
<scroller>
<div>
<div style="background-color: #286090">
<text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
</div>
<input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
</div>
<button class="button" @click="clickbutton">click</button>
</scroller>
</div>
</template>
<style scoped>
.input {
font-size: 60px;
height: 80px;
width: 750px;
}
.button {
font-size: 36;
width: 200px;
height: 200px;
color: #41B883;
text-align: center;
padding-top: 10;
padding-bottom: 10;
border-width: 2;
border-style: solid;
margin-right: 20;
border-color: rgb(162, 217, 192);
background-color: rgba(162, 217, 192, 0.2);
}
</style>
<script>
module.exports = {
data: function () {
return {
idCard:'',
};
},
methods: {
clickbutton: function () {
var that=this;
var modal = weex.requireModule('modal')
modal.toast({
message:"text:"+that.idCard,
duration: 0.3
})
},
oninput: function(event){
this.idCard = event.value;
console.log('oninput', event.value);
},
onchange: function (event) {
this.idCard = event.value;
console.log('onchange', event.value);
},
},
created(){
this.idCard = "1"
}
};
</script>
```
CheckList:
**if** *isBugFix* **:**
* [x] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marekchen/incubator-weex patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1048
----
commit f971a788b1d5c43b498d387be0372f8285528a7b
Author: marekchen <c4...@...>
Date: 2018-03-06T07:01:09Z
fix input bug
英文不好就用中文描述了：
1.当在created中设置input的value值为“1”，然后删除“1”，这时不会触发input事件
2.当输入“1”后，还是不能触发input事件，因为value值和输入值相同时，不触发input事件
重现代码如下：
``` html
<template>
<div>
<div>
<text style="font-size: 40px">oninput: {{idCard}}</text>
<text style="font-size: 40px">onchange: {{idCard}}</text>
</div>
<scroller>
<div>
<div style="background-color: #286090">
<text class="title" style="height: 80 ;padding: 20;color: #FFFFFF">input type = text</text>
</div>
<input type="text" :value="idCard" @input="oninput" @change="onchange" class="input" maxlength="18" ref="name2"/>
</div>
<button class="button" @click="clickbutton">click</button>
</scroller>
</div>
</template>
<style scoped>
.input {
font-size: 60px;
height: 80px;
width: 750px;
}
.button {
font-size: 36;
width: 200px;
height: 200px;
color: #41B883;
text-align: center;
padding-top: 10;
padding-bottom: 10;
border-width: 2;
border-style: solid;
margin-right: 20;
border-color: rgb(162, 217, 192);
background-color: rgba(162, 217, 192, 0.2);
}
</style>
<script>
module.exports = {
data: function () {
return {
idCard:'',
idCard1:'',
};
},
methods: {
clickbutton: function () {
var that=this;
var modal = weex.requireModule('modal')
modal.toast({
message:"text:"+that.idCard,
duration: 0.3
})
},
oninput: function(event){
this.idCard = event.value;
console.log('oninput', event.value);
},
onchange: function (event) {
this.idCard = event.value;
console.log('onchange', event.value);
},
},
created(){
this.idCard = "1"
}
};
</script>
```
----
---
[GitHub] incubator-weex issue #1048: [android]fix input bug
Posted by marekchen <gi...@git.apache.org>.
Github user marekchen commented on the issue:
https://github.com/apache/incubator-weex/pull/1048
can't reopen this pr
---
[GitHub] incubator-weex issue #1048: fix input bug
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1048
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #1048: fix input bug
Posted by marekchen <gi...@git.apache.org>.
Github user marekchen closed the pull request at:
https://github.com/apache/incubator-weex/pull/1048
---