You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/09/11 07:38:49 UTC

Review Request: Bug fixes for updates in executor launcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7005/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  src/launcher/launcher.cpp 0b9f066 
  src/slave/cgroups_isolation_module.cpp 34db9af 
  src/slave/process_based_isolation_module.cpp c0576bd 

Diff: https://reviews.apache.org/r/7005/diff/


Testing
-------

Not yet, just wanted to get this out quick ... will clean up any build issues in the morning.


Thanks,

Benjamin Hindman


Re: Review Request: Bug fixes for updates in executor launcher.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7005/#review11311
-----------------------------------------------------------



src/launcher/launcher.cpp
<https://reviews.apache.org/r/7005/#comment24322>

    s/;a/;


- Vinod Kone


On Sept. 11, 2012, 5:38 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7005/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:38 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 0b9f066 
>   src/slave/cgroups_isolation_module.cpp 34db9af 
>   src/slave/process_based_isolation_module.cpp c0576bd 
> 
> Diff: https://reviews.apache.org/r/7005/diff/
> 
> 
> Testing
> -------
> 
> Not yet, just wanted to get this out quick ... will clean up any build issues in the morning.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Bug fixes for updates in executor launcher.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7005/#review11313
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 11, 2012, 5:38 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7005/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2012, 5:38 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.cpp 0b9f066 
>   src/slave/cgroups_isolation_module.cpp 34db9af 
>   src/slave/process_based_isolation_module.cpp c0576bd 
> 
> Diff: https://reviews.apache.org/r/7005/diff/
> 
> 
> Testing
> -------
> 
> Not yet, just wanted to get this out quick ... will clean up any build issues in the morning.
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>