You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/09 01:53:40 UTC
[jira] [Commented] (DRILL-4491) FormatPluginOptionsDescriptor
requires FormatPluginConfig fields to be public
[ https://issues.apache.org/jira/browse/DRILL-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186220#comment-15186220 ]
ASF GitHub Bot commented on DRILL-4491:
---------------------------------------
GitHub user adityakishore opened a pull request:
https://github.com/apache/drill/pull/418
DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig…
… fields to be public
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adityakishore/drill DRILL-4491
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/418.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #418
----
commit cce8467c2476da871891bad7db6cab3236537f7c
Author: Aditya Kishore <ad...@apache.org>
Date: 2016-03-09T00:49:55Z
DRILL-4491: FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public
----
> FormatPluginOptionsDescriptor requires FormatPluginConfig fields to be public
> -----------------------------------------------------------------------------
>
> Key: DRILL-4491
> URL: https://issues.apache.org/jira/browse/DRILL-4491
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Aditya Kishore
> Assignee: Aditya Kishore
> Priority: Minor
> Fix For: 1.7.0
>
>
> The code uses {{getField()}} instead of {{getDeclaredField()}}, which returns only the public fields.
> {code:title=FormatPluginOptionsDescriptor.java:165|borderStyle=solid}
> Field field = pluginConfigClass.getField(paramDef.name);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)