You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/01/17 15:51:40 UTC
[commons-jexl] branch master updated: Pick up maven-checkstyle-plugin and checkstyle versions from parent POM
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git
The following commit(s) were added to refs/heads/master by this push:
new 97936f50 Pick up maven-checkstyle-plugin and checkstyle versions from parent POM
97936f50 is described below
commit 97936f5054f9023a36f6776f8b5c21d7a2194bc9
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Jan 17 10:51:35 2023 -0500
Pick up maven-checkstyle-plugin and checkstyle versions from parent POM
Also let the build be more repeatable by using the same checkstyle
version no matter the Java version
---
pom.xml | 31 -------------------------------
1 file changed, 31 deletions(-)
diff --git a/pom.xml b/pom.xml
index fa30eb5a..3af7ecee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -51,8 +51,6 @@
<commons.release.3.binary.suffix />
<commons.jira.id>JEXL</commons.jira.id>
<commons.jira.pid>12310479</commons.jira.pid>
- <checkstyle.plugin.version>3.2.1</checkstyle.plugin.version>
- <checkstyle.version>10.6.0</checkstyle.version>
<japicmp.skip>false</japicmp.skip>
<!-- override of Jacoco properties defined in CP52 -->
@@ -86,19 +84,6 @@
<commons.releaseManagerKey>4E066E0459CD109B</commons.releaseManagerKey>
</properties>
- <!-- Checkstyle 10 is incompatible with jdk 8, keep 9.3 -->
- <profiles>
- <profile>
- <id>jdk8-plugin-fix-version</id>
- <activation>
- <jdk>1.8</jdk>
- </activation>
- <properties>
- <checkstyle.version>9.3</checkstyle.version>
- </properties>
- </profile>
- </profiles>
-
<scm>
<connection>scm:git:https://gitbox.apache.org/repos/asf/commons-jexl.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/commons-jexl.git</developerConnection>
@@ -243,7 +228,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${checkstyle.plugin.version}</version>
<configuration>
<configLocation>${basedir}/src/main/config/checkstyle.xml</configLocation>
<suppressionsLocation>${basedir}/src/main/config/checkstyle-suppressions.xml</suppressionsLocation>
@@ -253,20 +237,6 @@
<!-- Needed to define config_loc for use by Eclipse -->
<propertyExpansion>config_loc=${basedir}/src/main/config</propertyExpansion>
</configuration>
- <!-- Update embedded checkstyle to latest -->
- <dependencies>
- <dependency>
- <groupId>com.puppycrawl.tools</groupId>
- <artifactId>checkstyle</artifactId>
- <version>${checkstyle.version}</version>
- <exclusions><!-- MCHECKSTYLE-156 -->
- <exclusion>
- <groupId>com.sun</groupId>
- <artifactId>tools</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- </dependencies>
</plugin>
<!-- Allow Spotbugs to be run from command-line. Must agree with config in report section. -->
@@ -386,7 +356,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${checkstyle.plugin.version}</version>
<configuration>
<configLocation>${basedir}/src/main/config/checkstyle.xml</configLocation>
<suppressionsLocation>${basedir}/src/main/config/checkstyle-suppressions.xml</suppressionsLocation>