You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/08/06 03:52:29 UTC

[GitHub] [incubator-shenyu] hongyiheng opened a new pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

hongyiheng opened a new pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887


   // Describe your PR here; eg. Fixes #issueNo
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor/).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887#issuecomment-894040796


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1887](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91e450f) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **increase** coverage by `0.03%`.
   > The diff coverage is `50.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1887      +/-   ##
   ============================================
   + Coverage     68.33%   68.37%   +0.03%     
   - Complexity     2710     2755      +45     
   ============================================
     Files           492      497       +5     
     Lines         11163    11303     +140     
     Branches       1091     1111      +20     
   ============================================
   + Hits           7628     7728     +100     
   - Misses         2959     3004      +45     
   + Partials        576      571       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../sync/data/websocket/WebsocketSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9XZWJzb2NrZXRTeW5jRGF0YVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...c/data/websocket/client/ShenyuWebsocketClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jbGllbnQvU2hlbnl1V2Vic29ja2V0Q2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/sync/data/websocket/config/WebsocketConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jb25maWcvV2Vic29ja2V0Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../sync/data/zookeeper/ZookeeperSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhU2VydmljZS5qYXZh) | `71.16% <ø> (-0.14%)` | :arrow_down: |
   | [...u/sync/data/consul/handler/ConsulCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2hhbmRsZXIvQ29uc3VsQ2FjaGVIYW5kbGVyLmphdmE=) | `81.13% <16.66%> (ø)` | |
   | [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `67.79% <20.00%> (ø)` | |
   | [...e/shenyu/sync/data/consul/config/ConsulConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2NvbmZpZy9Db25zdWxDb25maWcuamF2YQ==) | `36.84% <33.33%> (ø)` | |
   | [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `40.00% <36.84%> (ø)` | |
   | [...nyu/sync/data/nacos/handler/NacosCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3N5bmMvZGF0YS9uYWNvcy9oYW5kbGVyL05hY29zQ2FjaGVIYW5kbGVyLmphdmE=) | `77.46% <41.66%> (-0.15%)` | :arrow_down: |
   | [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `72.41% <50.00%> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...91e450f](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887#issuecomment-894040796


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1887](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91e450f) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.64%`.
   > The diff coverage is `49.49%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1887      +/-   ##
   ============================================
   - Coverage     68.33%   67.68%   -0.65%     
   - Complexity     2710     2739      +29     
   ============================================
     Files           492      497       +5     
     Lines         11163    11303     +140     
     Branches       1091     1110      +19     
   ============================================
   + Hits           7628     7651      +23     
   - Misses         2959     3075     +116     
   - Partials        576      577       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../sync/data/websocket/WebsocketSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9XZWJzb2NrZXRTeW5jRGF0YVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...c/data/websocket/client/ShenyuWebsocketClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jbGllbnQvU2hlbnl1V2Vic29ja2V0Q2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/sync/data/websocket/config/WebsocketConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jb25maWcvV2Vic29ja2V0Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../sync/data/zookeeper/ZookeeperSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhU2VydmljZS5qYXZh) | `71.16% <ø> (-0.14%)` | :arrow_down: |
   | [...u/sync/data/consul/handler/ConsulCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2hhbmRsZXIvQ29uc3VsQ2FjaGVIYW5kbGVyLmphdmE=) | `81.13% <16.66%> (ø)` | |
   | [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <20.00%> (-1.70%)` | :arrow_down: |
   | [...e/shenyu/sync/data/consul/config/ConsulConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2NvbmZpZy9Db25zdWxDb25maWcuamF2YQ==) | `36.84% <33.33%> (ø)` | |
   | [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `40.00% <36.84%> (ø)` | |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `63.10% <38.46%> (-11.66%)` | :arrow_down: |
   | [...nyu/sync/data/nacos/handler/NacosCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3N5bmMvZGF0YS9uYWNvcy9oYW5kbGVyL05hY29zQ2FjaGVIYW5kbGVyLmphdmE=) | `77.46% <41.66%> (-0.15%)` | :arrow_down: |
   | ... and [27 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...91e450f](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887#issuecomment-894040796


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1887](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91e450f) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.06%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1887      +/-   ##
   ============================================
   - Coverage     68.33%   68.26%   -0.07%     
   - Complexity     2710     2755      +45     
   ============================================
     Files           492      497       +5     
     Lines         11163    11303     +140     
     Branches       1091     1111      +20     
   ============================================
   + Hits           7628     7716      +88     
   - Misses         2959     3012      +53     
   + Partials        576      575       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../sync/data/websocket/WebsocketSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9XZWJzb2NrZXRTeW5jRGF0YVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...c/data/websocket/client/ShenyuWebsocketClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jbGllbnQvU2hlbnl1V2Vic29ja2V0Q2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/sync/data/websocket/config/WebsocketConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jb25maWcvV2Vic29ja2V0Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../sync/data/zookeeper/ZookeeperSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhU2VydmljZS5qYXZh) | `71.16% <ø> (-0.14%)` | :arrow_down: |
   | [...u/sync/data/consul/handler/ConsulCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2hhbmRsZXIvQ29uc3VsQ2FjaGVIYW5kbGVyLmphdmE=) | `81.13% <16.66%> (ø)` | |
   | [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `67.79% <20.00%> (ø)` | |
   | [...e/shenyu/sync/data/consul/config/ConsulConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2NvbmZpZy9Db25zdWxDb25maWcuamF2YQ==) | `36.84% <33.33%> (ø)` | |
   | [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `40.00% <36.84%> (ø)` | |
   | [...nyu/sync/data/nacos/handler/NacosCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3N5bmMvZGF0YS9uYWNvcy9oYW5kbGVyL05hY29zQ2FjaGVIYW5kbGVyLmphdmE=) | `77.46% <41.66%> (-0.15%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `65.04% <46.15%> (-9.71%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...91e450f](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887#issuecomment-894040796


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1887](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91e450f) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **increase** coverage by `0.03%`.
   > The diff coverage is `50.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1887      +/-   ##
   ============================================
   + Coverage     68.33%   68.37%   +0.03%     
   - Complexity     2710     2755      +45     
   ============================================
     Files           492      497       +5     
     Lines         11163    11303     +140     
     Branches       1091     1111      +20     
   ============================================
   + Hits           7628     7728     +100     
   - Misses         2959     3004      +45     
   + Partials        576      571       -5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../sync/data/websocket/WebsocketSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9XZWJzb2NrZXRTeW5jRGF0YVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...c/data/websocket/client/ShenyuWebsocketClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jbGllbnQvU2hlbnl1V2Vic29ja2V0Q2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/sync/data/websocket/config/WebsocketConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jb25maWcvV2Vic29ja2V0Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../sync/data/zookeeper/ZookeeperSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhU2VydmljZS5qYXZh) | `71.16% <ø> (-0.14%)` | :arrow_down: |
   | [...u/sync/data/consul/handler/ConsulCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2hhbmRsZXIvQ29uc3VsQ2FjaGVIYW5kbGVyLmphdmE=) | `81.13% <16.66%> (ø)` | |
   | [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `67.79% <20.00%> (ø)` | |
   | [...e/shenyu/sync/data/consul/config/ConsulConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2NvbmZpZy9Db25zdWxDb25maWcuamF2YQ==) | `36.84% <33.33%> (ø)` | |
   | [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `40.00% <36.84%> (ø)` | |
   | [...nyu/sync/data/nacos/handler/NacosCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3N5bmMvZGF0YS9uYWNvcy9oYW5kbGVyL05hY29zQ2FjaGVIYW5kbGVyLmphdmE=) | `77.46% <41.66%> (-0.15%)` | :arrow_down: |
   | [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `72.41% <50.00%> (ø)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...91e450f](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 merged pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1887: refactor:[ISSUE #1866] remove lombok dependency

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1887:
URL: https://github.com/apache/incubator-shenyu/pull/1887#issuecomment-894040796


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1887](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91e450f) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/fced0b9fa5f8970dd5f9b539638f47a536c050d9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fced0b9) will **decrease** coverage by `0.07%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1887      +/-   ##
   ============================================
   - Coverage     68.33%   68.25%   -0.08%     
   - Complexity     2710     2754      +44     
   ============================================
     Files           492      497       +5     
     Lines         11163    11303     +140     
     Branches       1091     1111      +20     
   ============================================
   + Hits           7628     7715      +87     
   - Misses         2959     3013      +54     
   + Partials        576      575       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../sync/data/websocket/WebsocketSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9XZWJzb2NrZXRTeW5jRGF0YVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...c/data/websocket/client/ShenyuWebsocketClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jbGllbnQvU2hlbnl1V2Vic29ja2V0Q2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...in/sync/data/websocket/config/WebsocketConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS13ZWJzb2NrZXQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc3luYy9kYXRhL3dlYnNvY2tldC9jb25maWcvV2Vic29ja2V0Q29uZmlnLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../sync/data/zookeeper/ZookeeperSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvem9va2VlcGVyL1pvb2tlZXBlclN5bmNEYXRhU2VydmljZS5qYXZh) | `71.16% <ø> (-0.14%)` | :arrow_down: |
   | [...u/sync/data/consul/handler/ConsulCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2hhbmRsZXIvQ29uc3VsQ2FjaGVIYW5kbGVyLmphdmE=) | `81.13% <16.66%> (ø)` | |
   | [...shenyu/sync/data/consul/ConsulSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL0NvbnN1bFN5bmNEYXRhU2VydmljZS5qYXZh) | `66.10% <20.00%> (-1.70%)` | :arrow_down: |
   | [...e/shenyu/sync/data/consul/config/ConsulConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9zeW5jL2RhdGEvY29uc3VsL2NvbmZpZy9Db25zdWxDb25maWcuamF2YQ==) | `36.84% <33.33%> (ø)` | |
   | [...pache/shenyu/sync/data/http/config/HttpConfig.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvY29uZmlnL0h0dHBDb25maWcuamF2YQ==) | `40.00% <36.84%> (ø)` | |
   | [...nyu/sync/data/nacos/handler/NacosCacheHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3N5bmMvZGF0YS9uYWNvcy9oYW5kbGVyL05hY29zQ2FjaGVIYW5kbGVyLmphdmE=) | `77.46% <41.66%> (-0.15%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `65.04% <46.15%> (-9.71%)` | :arrow_down: |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1887/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fced0b9...91e450f](https://codecov.io/gh/apache/incubator-shenyu/pull/1887?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org