You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "KamToHung (via GitHub)" <gi...@apache.org> on 2025/09/21 03:35:37 UTC

[PR] fix: update environment variable references in README and server files [dubbo-go-samples]

KamToHung opened a new pull request, #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931

   #930 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] fix: update environment variable references in README and server files [dubbo-go-samples]

Posted by "KamToHung (via GitHub)" <gi...@apache.org>.
KamToHung commented on code in PR #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931#discussion_r2366255751


##########
compatibility/direct/README_zh.md:
##########
@@ -146,7 +146,7 @@ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
 
 ```shell
 APP_LOG_CONF_FILE=direct/go-server/conf/log.yml;
-CONF_PROVIDER_FILE_PATH=direct/go-server/conf/server.yml
+DUBBO_GO_CONFIG_PATH=direct/go-server/conf/server.yml

Review Comment:
   > provider 这个名字不要丢
   
   适配旧版本,保留吗



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] fix: update environment variable references in README and server files [dubbo-go-samples]

Posted by "KamToHung (via GitHub)" <gi...@apache.org>.
KamToHung commented on code in PR #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931#discussion_r2366255751


##########
compatibility/direct/README_zh.md:
##########
@@ -146,7 +146,7 @@ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
 
 ```shell
 APP_LOG_CONF_FILE=direct/go-server/conf/log.yml;
-CONF_PROVIDER_FILE_PATH=direct/go-server/conf/server.yml
+DUBBO_GO_CONFIG_PATH=direct/go-server/conf/server.yml

Review Comment:
   > provider 这个名字不要丢
   
   适配旧版本保留吗,现在samples用的是dubbo-go v3.3.0,找不到CONF_PROVIDER_FILE_PATH



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] fix: update environment variable references in README and server files [dubbo-go-samples]

Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931#discussion_r2365947969


##########
compatibility/direct/README.md:
##########
@@ -145,7 +145,7 @@ Configure the environment variable to specify the configuration file path requir
 
 ```shell
 APP_LOG_CONF_FILE=direct/go-server/conf/log.yml;
-CONF_PROVIDER_FILE_PATH=direct/go-server/conf/server.yml
+DUBBO_GO_CONFIG_PATH=direct/go-server/conf/server.yml

Review Comment:
   provider 这个名字不要丢



##########
compatibility/direct/README_zh.md:
##########
@@ -146,7 +146,7 @@ err := userProvider.GetUser(context.TODO(), []interface{}{"A001"}, user)
 
 ```shell
 APP_LOG_CONF_FILE=direct/go-server/conf/log.yml;
-CONF_PROVIDER_FILE_PATH=direct/go-server/conf/server.yml
+DUBBO_GO_CONFIG_PATH=direct/go-server/conf/server.yml

Review Comment:
   provider 这个名字不要丢



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] fix: update environment variable references in README and server files [dubbo-go-samples]

Posted by "1kasa (via GitHub)" <gi...@apache.org>.
1kasa commented on PR #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931#issuecomment-3415702405

   fix ci error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] fix: update environment variable references in README and server files [dubbo-go-samples]

Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #931:
URL: https://github.com/apache/dubbo-go-samples/pull/931


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org