[jira] Commented: (OODT-41) Product Constructor does not set transfer status.

["Brian Foster (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OODT-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971503#action_12971503 ] 

Brian Foster commented on OODT-41:
----------------------------------


- however, the Product object has a argument which it doesn't use . . . this is misleading . . . why is it okay for the Product constructor to just ignore its structure argument . . . we are talking about a one like fix, adding the following to the constructor: productStructure = structure . . . otherwise i would argue that constructor be deprecated and another one be created without the 'String structure' argument.

> Product Constructor does not set transfer status.
> -------------------------------------------------
>
>                 Key: OODT-41
>                 URL: https://issues.apache.org/jira/browse/OODT-41
>             Project: OODT
>          Issue Type: Bug
>          Components: file manager
>            Reporter: Paul Ramirez
>            Priority: Minor
>             Fix For: 0.2
>
>
> The construtor below takes in transferStatus but does nothing with it. Not sure if would break code to change this. Probably requires an update to a unit test too. 
> public Product(String name, ProductType pType, String structure,
>             String transferStatus, List<Reference> refs) {
>         productName = name;
>         productType = pType;
>         productStructure = structure;
>         references = refs;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.