You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2017/12/08 10:07:19 UTC

[GitHub] resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r155742019
 
 

 ##########
 File path: systemvm/debian/etc/systemd/system/cloud-password-server@.service
 ##########
 @@ -0,0 +1,11 @@
+[Unit]
+Description=Cloud password server on %I
+After=network.target local-fs.target
+
+[Install]
+WantedBy=multi-user.target
+
+[Service]
+Type=simple
+WorkingDirectory=/opt/cloud/bin
+ExecStart=/opt/cloud/bin/passwd_server_ip.py %I
 
 Review comment:
   I would suggest to add 
   ~~~diff
   +Restart=on-failure
   ~~~
   https://www.freedesktop.org/software/systemd/man/systemd.service.html#Restart=
   
   Probably check if this service could run as user "cloud".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services