You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2016/02/27 01:35:17 UTC
Review Request 44119: Alerts for PXF component status
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211
Repository: ambari
Description
-------
Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version api)
Diffs
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/44119/diff/
Testing
-------
Manually tested.
----------------------------------------------------------------------
Ran 275 tests in 6.876s
OK
----------------------------------------------------------------------
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
jun aoki
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 12:49 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 90
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line90>
> >
> > There is one makeHTTPCall() in Pxfutils.py. Is this doing anything different. If yes, overloaded method can be used there.
@Matt told you can not import anything from main code, thus it is duplicated here.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121021
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121021
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 90)
<https://reviews.apache.org/r/44119/#comment182605>
There is one makeHTTPCall() in Pxfutils.py. Is this doing anything different. If yes, overloaded method can be used there.
- Goutam Tadi
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:02 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 65
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line65>
> >
> > Do you want a ")" at the end for the comment?
thank you for letting me know. This line should be actually deleted. (some old code)
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121030
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121030
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 65)
<https://reviews.apache.org/r/44119/#comment182614>
Do you want a ")" at the end for the comment?
- Goutam Tadi
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 157
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line157>
> >
> > Is there a case where the alert is CRITICAL?
> >
> > If PXF component which is on the same host as NAMENODE, would that be CRITICAL? Or PXF service would still be operational as a whole relying on other PXF hostcomponents.
Good that you brought up. I will stick with WARNING since a PXF being down is not a critical situation, but I will follow up for other cases where it should be CRITICAL and will make jira tickets.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 72
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line72>
> >
> > The log is common to all alerts which are run. It would be better to say which alert it is, for making debugging easier in the future.
> >
> > logger.info("[Alert PXF API]: getting delegation token from {0}".format(url))
> >
> > Consider other logger messages as well.
>
> jun aoki wrote:
> @Matt, I wonder if all callers of logger have to write where it is, it would defeat the purpose of logger? The callers should only write level (info, debug, warn) and what it wants to log.
> On the other hand, timestamp, py file name and possibly lines should be logged by logger only when it is configured so? (also see log4j's "F" format)
> Let me know if I'm totally mistaken here with python's logger.
>
> Matt wrote:
> Among a bunch of log messages, it would be easier to identify the message if it contained 'PXF' in the message: "Getting delegation token from <url> for PXF".
> At-least it makes it possible to grep for PXF in the ambari_alerts log and this would show up, without possibly thinking about enabling other log4j options (similar to the one you mentioned).
>
> "Getting delegation token from <url>" can be for any alert defined in Ambari. grepping for PXF wouldn't return this line.
Good point. will append "for PXF" in the message
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
On March 1, 2016, 2:10 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 2:10 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 72
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line72>
> >
> > The log is common to all alerts which are run. It would be better to say which alert it is, for making debugging easier in the future.
> >
> > logger.info("[Alert PXF API]: getting delegation token from {0}".format(url))
> >
> > Consider other logger messages as well.
@Matt, I wonder if all callers of logger have to write where it is, it would defeat the purpose of logger? The callers should only write level (info, debug, warn) and what it wants to log.
On the other hand, timestamp, py file name and possibly lines should be logged by logger only when it is configured so? (also see log4j's "F" format)
Let me know if I'm totally mistaken here with python's logger.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Matt <mi...@gmail.com>.
> On Feb. 26, 2016, 5:11 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 72
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line72>
> >
> > The log is common to all alerts which are run. It would be better to say which alert it is, for making debugging easier in the future.
> >
> > logger.info("[Alert PXF API]: getting delegation token from {0}".format(url))
> >
> > Consider other logger messages as well.
>
> jun aoki wrote:
> @Matt, I wonder if all callers of logger have to write where it is, it would defeat the purpose of logger? The callers should only write level (info, debug, warn) and what it wants to log.
> On the other hand, timestamp, py file name and possibly lines should be logged by logger only when it is configured so? (also see log4j's "F" format)
> Let me know if I'm totally mistaken here with python's logger.
Among a bunch of log messages, it would be easier to identify the message if it contained 'PXF' in the message: "Getting delegation token from <url> for PXF".
At-least it makes it possible to grep for PXF in the ambari_alerts log and this would show up, without possibly thinking about enabling other log4j options (similar to the one you mentioned).
"Getting delegation token from <url>" can be for any alert defined in Ambari. grepping for PXF wouldn't return this line.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
On Feb. 29, 2016, 6:10 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 6:10 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:11 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 150
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line150>
> >
> > The part of the message 'PXF is not functional' is already covered on Line 155. If you don't want to repeat the same information, you may delete it.
Good point. will delete it.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121027
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 72)
<https://reviews.apache.org/r/44119/#comment182610>
The log is common to all alerts which are run. It would be better to say which alert it is, for making debugging easier in the future.
logger.info("[Alert PXF API]: getting delegation token from {0}".format(url))
Consider other logger messages as well.
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 150)
<https://reviews.apache.org/r/44119/#comment182617>
The part of the message 'PXF is not functional' is already covered on Line 155. If you don't want to repeat the same information, you may delete it.
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 157)
<https://reviews.apache.org/r/44119/#comment182619>
Is there a case where the alert is CRITICAL?
If PXF component which is on the same host as NAMENODE, would that be CRITICAL? Or PXF service would still be operational as a whole relying on other PXF hostcomponents.
- Matt
On Feb. 26, 2016, 4:35 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:35 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121548
-----------------------------------------------------------
Ship it!
Ship It!
- Oleksandr Diachenko
On March 1, 2016, 9:13 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 9:13 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
-----------------------------------------------------------
(Updated March 3, 2016, 12:16 a.m.)
Review request for Ambari.
Changes
-------
slight text label change
Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211
Repository: ambari
Description
-------
Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version api)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/metainfo.xml 4078990
ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 1797b29
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/44119/diff/
Testing
-------
Manually tested.
----------------------------------------------------------------------
Ran 275 tests in 6.876s
OK
----------------------------------------------------------------------
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
jun aoki
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
-----------------------------------------------------------
(Updated March 1, 2016, 9:13 p.m.)
Review request for Ambari.
Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211
Repository: ambari
Description
-------
Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version api)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/44119/diff/
Testing
-------
Manually tested.
----------------------------------------------------------------------
Ran 275 tests in 6.876s
OK
----------------------------------------------------------------------
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
jun aoki
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
-----------------------------------------------------------
(Updated March 1, 2016, 2:10 a.m.)
Review request for Ambari.
Changes
-------
feedback applied
Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211
Repository: ambari
Description
-------
Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version api)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/44119/diff/
Testing
-------
Manually tested.
----------------------------------------------------------------------
Ran 275 tests in 6.876s
OK
----------------------------------------------------------------------
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
jun aoki
Re: Review Request 44119: Alerts for PXF component status
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121378
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 87)
<https://reviews.apache.org/r/44119/#comment183051>
+1 for using Fail instead of Exception. Some of try-except blocks might expect type Fail, not Exception and exception wouldn't be handled propertly.
- Oleksandr Diachenko
On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 106
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line106>
> >
> > Extra space and colon needed?
Good point. will fix.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
-----------------------------------------------------------
On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 88
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line88>
> >
> > +1 for using Fail instead of Exception. Some of try-except blocks might be expection type Fail, not Exception and exception wouldn't be handled propertly.
Actually this script itself is the one who handles it, and it handles Exception, instead of Fail.
> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 121
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line121>
> >
> > Better to raise Fail.
Same as above
> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 127
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line127>
> >
> > There is JIRA in current trunk, which changed version response to this format:
> > { "version": "v14"}
> > https://issues.apache.org/jira/browse/HAWQ-340
> >
> > So patch for trunk might be expect new response format.
Yes, the new version is what we certify here. (See also the unit test)
> On March 1, 2016, 1:38 a.m., Oleksandr Diachenko wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, line 26
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line26>
> >
> > Are we using all files which we are importing? If no, I would explicitly import whatever you need only.
Good point. WIll fix it.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
-----------------------------------------------------------
On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Oleksandr Diachenko <od...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121376
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 88)
<https://reviews.apache.org/r/44119/#comment183046>
+1 for using Fail instead of Exception. Some of try-except blocks might be expection type Fail, not Exception and exception wouldn't be handled propertly.
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 106)
<https://reviews.apache.org/r/44119/#comment183050>
Extra space and colon needed?
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 121)
<https://reviews.apache.org/r/44119/#comment183047>
Better to raise Fail.
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 127)
<https://reviews.apache.org/r/44119/#comment183048>
There is JIRA in current trunk, which changed version response to this format:
{ "version": "v14"}
https://issues.apache.org/jira/browse/HAWQ-340
So patch for trunk might be expect new response format.
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py (line 26)
<https://reviews.apache.org/r/44119/#comment183049>
Are we using all files which we are importing? If no, I would explicitly import whatever you need only.
- Oleksandr Diachenko
On Feb. 29, 2016, 11:50 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 11:50 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 11:50 p.m.)
Review request for Ambari.
Changes
-------
Applied feedback
Bugs: AMBARI-15211
https://issues.apache.org/jira/browse/AMBARI-15211
Repository: ambari
Description
-------
Add alerts for PXF availability.
The availability could be same as its service check. (by hitting the version api)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
Diff: https://reviews.apache.org/r/44119/diff/
Testing
-------
Manually tested.
----------------------------------------------------------------------
Ran 275 tests in 6.876s
OK
----------------------------------------------------------------------
Total run:924
Total errors:0
Total failures:0
OK
Thanks,
jun aoki
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 112
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line112>
> >
> > When I went through other methods in PXF we followed a convention "__get_pxf_protocol" (used double underscore at start). Though it does not affect the functionality, I would just like to give a hint.
I have a unit test that refers the method and if it 2 double underscores, the test won't be able to see it.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 21
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line21>
> >
> > I see other implementations used
> > ```
> > from resource_management.core.logger import Logger
> > ```
> > Can we consider this for logging?
I followed this convention
https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_sync_status.py#L35
Let me know if you have a strong preference for the change.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121028
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 21)
<https://reviews.apache.org/r/44119/#comment182613>
I see other implementations used
```
from resource_management.core.logger import Logger
```
Can we consider this for logging?
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 112)
<https://reviews.apache.org/r/44119/#comment182611>
When I went through other methods in PXF we followed a convention "__get_pxf_protocol" (used double underscore at start). Though it does not affect the functionality, I would just like to give a hint.
- Goutam Tadi
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 1:09 a.m., Goutam Tadi wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py, line 88
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272830#file1272830line88>
> >
> > raise Exception(msg) or raise Fail(msg) ? I see throwing Fail(msg) in implementation.
Intresting. It is acutally the same thing
https://github.com/apache/ambari/blob/trunk/ambari-common/src/main/python/resource_management/core/exceptions.py#L25
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121031
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121031
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 88)
<https://reviews.apache.org/r/44119/#comment182618>
raise Exception(msg) or raise Fail(msg) ? I see throwing Fail(msg) in implementation.
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py (line 155)
<https://reviews.apache.org/r/44119/#comment182616>
I dont think we need to convert "e" to string explicitly. Correct me!!
- Goutam Tadi
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by jun aoki <ju...@gmail.com>.
> On Feb. 27, 2016, 12:45 a.m., Goutam Tadi wrote:
> > ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py, line 28
> > <https://reviews.apache.org/r/44119/diff/1/?file=1272831#file1272831line28>
> >
> > Can we use like the one following
> > ```
> > COMMON_SERVICES_PACKAGE_DIR = "PXF/3.0.0/package"
> > ```
> >
> > in ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py
I am kind of mimicing this https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py#L33 but use a bunch of ".." instead of a bunch of dirname methods.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121020
-----------------------------------------------------------
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 44119: Alerts for PXF component status
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44119/#review121020
-----------------------------------------------------------
ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py (line 28)
<https://reviews.apache.org/r/44119/#comment182604>
Can we use like the one following
```
COMMON_SERVICES_PACKAGE_DIR = "PXF/3.0.0/package"
```
in ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py
- Goutam Tadi
On Feb. 27, 2016, 12:35 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44119/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2016, 12:35 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15211
> https://issues.apache.org/jira/browse/AMBARI-15211
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add alerts for PXF availability.
> The availability could be same as its service check. (by hitting the version api)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/alerts/api_status.py PRE-CREATION
> ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44119/diff/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> ----------------------------------------------------------------------
> Ran 275 tests in 6.876s
>
> OK
> ----------------------------------------------------------------------
> Total run:924
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> jun aoki
>
>