[GitHub] [flink] tillrohrmann commented on a change in pull request #12814: [FLINK-12336][monitoring] Add HTTPS support to InfluxDB reporter

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #12814:
URL: https://github.com/apache/flink/pull/12814#discussion_r449461013



##########
File path: flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -127,6 +127,7 @@ public void testMetricReporting() throws Exception {
 
 	private MetricRegistryImpl createMetricRegistry(String retentionPolicy, InfluxDB.ConsistencyLevel consistencyLevel) {
 		MetricConfig metricConfig = new MetricConfig();
+		metricConfig.setProperty(InfluxdbReporterOptions.SCHEME.key(), "http");

Review comment:
       I think this should not be necessary since `http` is the default value.

##########
File path: flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterOptions.java
##########
@@ -36,6 +36,12 @@
 		.noDefaultValue()
 		.withDescription("the InfluxDB server host");
 
+	public static final ConfigOption<String> SCHEME = ConfigOptions
+		.key("scheme")
+		.stringType()

Review comment:
       We could introduce a `Scheme` enum which defines the valid values `http`/`https`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org