[jira] [Commented] (KAFKA-6381) Improve KafkaStreamsTest for localThreadMetadata

["Boyang Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351866#comment-16351866 ] 

Boyang Chen commented on KAFKA-6381:
------------------------------------

[~mjsax] I did have a try on this one, and found that I could not come up with a valid mock KStreams. So leaving this one unassigned right now since I might not have time to tackle it. Sorry for taking so long to response!

> Improve KafkaStreamsTest for localThreadMetadata
> ------------------------------------------------
>
>                 Key: KAFKA-6381
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6381
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams, unit tests
>            Reporter: Matthias J. Sax
>            Priority: Minor
>
> Currently, we have a rather basic test for {{KafkaStreams#localThreadMetadata}} (ie, {{KafkaStreamsTests#shouldReturnThreadMetadata()}}.
> In a PR discussion [~guozhang] mentioned:
> {quote}
> I'm wondering if it is better to fill into the topology with some processor and then check the following active and standby tasks as non-empty would cover more scenarios? In addition, we can use waitForCondition to wait for the state to become RUNNING and the tasks list become non-empty.
> {quote}
> We should extend the current test method and/or add new test methods to cover this and other scenario.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)