You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 06:23:05 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
mistercrunch opened a new pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283
Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.
closes https://github.com/apache/incubator-superset/issues/10247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283#issuecomment-656512031
@villebro let's make sure this makes 0.37!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283#issuecomment-656538678
Yeah I noticed after the fact that the action is not bound and doesn't get dispatched. It does fix the menu, the modal showing up and actually saves, but changes are not reflected in the redux state...
Thanks for taking this over @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283#issuecomment-656518305
This probably doesn't fix the onSave behavior, I'll make another followup PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #10283: fix(explore): 'Edit Datasource' is missing from btn-dropdown
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #10283:
URL: https://github.com/apache/incubator-superset/pull/10283#issuecomment-656518305
This probably doesn't fix the onSave behavior---the action will not be actually dispatched, I'll make another followup PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org