You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/18 17:39:55 UTC
[GitHub] [incubator-pinot] mqliang opened a new pull request #6694: Remove unused variable in ServerQueryExecutorV1Impl and unnecessary check in ThreadTimer
mqliang opened a new pull request #6694:
URL: https://github.com/apache/incubator-pinot/pull/6694
## Description
As discussed in https://github.com/apache/incubator-pinot/pull/6680, this PR to some code cleanup:
* remove unused variable in ServerQueryExecutorV1Impl
* remove unnecessary check in ThreadTimer. Instead, if thread cpu timing is not enabled, return 0.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6694: Remove unused variable in ServerQueryExecutorV1Impl and unnecessary check in ThreadTimer
Posted by GitBox <gi...@apache.org>.
mqliang commented on a change in pull request #6694:
URL: https://github.com/apache/incubator-pinot/pull/6694#discussion_r597112072
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##########
@@ -55,7 +55,7 @@ public void stop() {
}
public long getThreadTimeNs() {
- if (_startTimeNs == -1 || _endTimeNs == -1) {
+ if (!IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED) {
Review comment:
You are right, if thread cpu timing is not enabled, `_startTimeNs == -1 && _endTimeNs == -1`, so `_endTimeNs - _startTimeNs = 0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6694: Remove unused variable in ServerQueryExecutorV1Impl and unnecessary check in ThreadTimer
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #6694:
URL: https://github.com/apache/incubator-pinot/pull/6694#discussion_r597108446
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##########
@@ -55,7 +55,7 @@ public void stop() {
}
public long getThreadTimeNs() {
- if (_startTimeNs == -1 || _endTimeNs == -1) {
+ if (!IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED) {
Review comment:
This check is actually redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6694: Remove unused variable in ServerQueryExecutorV1Impl and unnecessary check in ThreadTimer
Posted by GitBox <gi...@apache.org>.
mqliang commented on a change in pull request #6694:
URL: https://github.com/apache/incubator-pinot/pull/6694#discussion_r597198116
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/ThreadTimer.java
##########
@@ -55,7 +55,7 @@ public void stop() {
}
public long getThreadTimeNs() {
- if (_startTimeNs == -1 || _endTimeNs == -1) {
+ if (!IS_THREAD_CPU_TIME_MEASUREMENT_ENABLED) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia merged pull request #6694: Remove unused variable in ServerQueryExecutorV1Impl and unnecessary check in ThreadTimer
Posted by GitBox <gi...@apache.org>.
siddharthteotia merged pull request #6694:
URL: https://github.com/apache/incubator-pinot/pull/6694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org