You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ShivsundarR (via GitHub)" <gi...@apache.org> on 2025/05/02 09:58:09 UTC
[PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]
ShivsundarR opened a new pull request, #19619:
URL: https://github.com/apache/kafka/pull/19619
*What*
https://issues.apache.org/jira/browse/KAFKA-19232
Handle the new `ShareSessionLimitReachedException` in `ShareSessionHandler` in the client to reset the ShareSession.
Added a unit test verifying the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]
Posted by "ShivsundarR (via GitHub)" <gi...@apache.org>.
ShivsundarR commented on code in PR #19619:
URL: https://github.com/apache/kafka/pull/19619#discussion_r2072539685
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareSessionHandler.java:
##########
@@ -219,7 +219,8 @@ private String topicIdPartitionsToLogString(Collection<TopicIdPartition> partiti
*/
public boolean handleResponse(ShareFetchResponse response, short version) {
if ((response.error() == Errors.SHARE_SESSION_NOT_FOUND) ||
- (response.error() == Errors.INVALID_SHARE_SESSION_EPOCH)) {
+ (response.error() == Errors.INVALID_SHARE_SESSION_EPOCH ||
Review Comment:
Thanks, I have updated them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #19619:
URL: https://github.com/apache/kafka/pull/19619#discussion_r2071867706
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareSessionHandler.java:
##########
@@ -219,7 +219,8 @@ private String topicIdPartitionsToLogString(Collection<TopicIdPartition> partiti
*/
public boolean handleResponse(ShareFetchResponse response, short version) {
if ((response.error() == Errors.SHARE_SESSION_NOT_FOUND) ||
- (response.error() == Errors.INVALID_SHARE_SESSION_EPOCH)) {
+ (response.error() == Errors.INVALID_SHARE_SESSION_EPOCH ||
Review Comment:
nit: The parentheses here are wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19232: Handle Share session limit reached exception in clients. [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #19619:
URL: https://github.com/apache/kafka/pull/19619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org