You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/09 05:58:21 UTC
[GitHub] [druid] himanshug opened a new pull request #9480: remove old
unused zookeeper dependent lookups code
himanshug opened a new pull request #9480: remove old unused zookeeper dependent lookups code
URL: https://github.com/apache/druid/pull/9480
Paving Path Towards #9053
### Description
This patch removes a bunch of lookups discovery code with hard coded use of Zookeeper. This code is no longer used at all and was originally kept to allow smooth transition to http based lookups management which is used currently by the coordinator for lookups management.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug merged pull request #9480: remove old unused
zookeeper dependent lookups code
Posted by GitBox <gi...@apache.org>.
himanshug merged pull request #9480: remove old unused zookeeper dependent lookups code
URL: https://github.com/apache/druid/pull/9480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on issue #9480: remove old unused
zookeeper dependent lookups code
Posted by GitBox <gi...@apache.org>.
himanshug commented on issue #9480: remove old unused zookeeper dependent lookups code
URL: https://github.com/apache/druid/pull/9480#issuecomment-597263582
@clintropolis thanks for quick review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org