[jira] Closed: (OFBIZ-1920) Patch to add support for Postgresql with TEXT type fields

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-1920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-1920.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Philip,

Your, slightly modified, patch is in trunk revision: 697967  


> Patch to add support for Postgresql with TEXT type fields
> ---------------------------------------------------------
>
>                 Key: OFBIZ-1920
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1920
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>         Environment: Centos 5.3 Postgres 8.1
>            Reporter: Philip W. Dalrymple III
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: patch-text.01, postgres-text.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Postgres does not require any extra cycles to support very long text
> fields, see the manuals at 8.3. Character Types.
>     Tip:  There are no performance differences between these three types, apart from increased storage
>       size when using the blank-padded type, and a few extra cycles to check the length when storing
>       into a length-constrained column. While character(n) has performance advantages in some other
>       database systems, it has no such advantages in PostgreSQL. In most situations text or character
>       varying should be used instead.
> This is a feature that I have always (well from 7.x where it was added) and in general use TEXT for
> all of my strings.
> Attached is a patch that I have build wrt OfBiz r685532 that adds a new field type file that is a
> copy of the postgresql types except that all of the varchar fields are changed to text.
> I have installed this on a new copy of OfBiz and ran the system in demo/test and it appears not to
> have any problems. The only limit on this is that data dumps from such a system may not be loadable
> on a system running another fieldtype file.
> The nature of this change is very simple but if it is necessary for me to file a copyright assigment
> let me know.
> Testing, Review and Commitment is all that is needed to close this issue.
> NOTE that I don't know what effect changing the field type from postgers to postnew will have, it MIGHT change all of the field types and it might break th
> DB, I HAVE NOT TESTED THIS CONDITION!!!!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.