You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/24 15:11:24 UTC

[jira] [Commented] (FLINK-971) Configure Netty ByteBufAllocator instead of using the default configuration

    [ https://issues.apache.org/jira/browse/FLINK-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042083#comment-14042083 ] 

ASF GitHub Bot commented on FLINK-971:
--------------------------------------

GitHub user uce opened a pull request:

    https://github.com/apache/incubator-flink/pull/38

    [FLINK-971] Configure PooledByteBufAllocator in NettyConnectionManager

    ...instead of using the default allocator
    
    Configuration:
        - 0 heap arenas,
        - n direct arenas (where n = num incoming + num outgoing network IO threads), and
        - bufferSize << 1 bytes page size.
    
    Additionally, `OutboundEnvelopeEncoder` directly implements `ChannelOutboundHandlerAdapter` instead of the
    `MessageToByteEncoder<Envelope>` wrapper to have tighter control of memory allocations.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/incubator-flink FLINK-971

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit 59e0ab867ecef5602cb8e05109a3ffd019f94536
Author: uce <u....@fu-berlin.de>
Date:   2014-06-17T14:18:02Z

    [FLINK-971] Configure PooledByteBufAllocator in NettyConnectionManager instead of using the default allocator
    
    Configuration:
        - 0 heap arenas,
        - n direct arenas (where n = num incoming + num outgoing network IO threads), and
        - bufferSize << 1 bytes page size.
    
    Additionally, OutboundEnvelopeEncoder directly implements ChannelOutboundHandlerAdapter instead of the
    MessageToByteEncoder<Envelope> wrapper to have tighter control of memory allocations.

----


> Configure Netty ByteBufAllocator instead of using the default configuration
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-971
>                 URL: https://issues.apache.org/jira/browse/FLINK-971
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>    Affects Versions: pre-apache-0.5.1
>            Reporter: Ufuk Celebi
>            Priority: Minor
>
> {{NettyConnectionManager}} uses the {{PooledByteBufAllocator.DEFAULT}} allocator, which allocates unnecessary heap arenas, which are never used. Also, the page size is smaller than our buffer size (+ headers etc.), which results in page-boundery crossing allocations.



--
This message was sent by Atlassian JIRA
(v6.2#6252)