You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/07 17:39:17 UTC
[GitHub] [tvm] cconvey opened a new pull request, #11608: [python][docs] fix docstring typo
cconvey opened a new pull request, #11608:
URL: https://github.com/apache/tvm/pull/11608
CC: @jcf94
Thanks @octoJon for pointing out the typo!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r904947002
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -98,8 +98,8 @@ class XGBModel(PythonBasedModel):
The random seed
model_file: Optional[str]
If is not None, save model to this file after every update.
- adapative_training: bool = False
- Whether to use adapatie training, which reduces the training frequency when there are
+ adaptive_training: bool = False
+ Whether to use adapative training, which reduces the training frequency when there are
Review Comment:
:facepalm: :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
comaniac commented on PR #11608:
URL: https://github.com/apache/tvm/pull/11608#issuecomment-1164694130
Thanks @cconvey @octoJon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r891573845
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Review Comment:
> Oh, shoot, but the parameter name itself actually has the extra 'a'... Well, sorry for what I thought was just a comment fix which now looks like it requires fixing spelling within the code.
Good catch! I'll update the PR to fix it everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r891575992
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Review Comment:
PR updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on PR #11608:
URL: https://github.com/apache/tvm/pull/11608#issuecomment-1152516400
@comaniac @merrymercy: Mind giving this a review and (if okay) merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
comaniac commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r894981803
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -98,8 +98,8 @@ class XGBModel(PythonBasedModel):
The random seed
model_file: Optional[str]
If is not None, save model to this file after every update.
- adapative_training: bool = False
- Whether to use adapatie training, which reduces the training frequency when there are
+ adaptive_training: bool = False
+ Whether to use adapative training, which reduces the training frequency when there are
Review Comment:
adaptive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on PR #11608:
URL: https://github.com/apache/tvm/pull/11608#issuecomment-1164663345
@comaniac @merrymercy: Would one of you mind giving this a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
cconvey commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r904947002
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -98,8 +98,8 @@ class XGBModel(PythonBasedModel):
The random seed
model_file: Optional[str]
If is not None, save model to this file after every update.
- adapative_training: bool = False
- Whether to use adapatie training, which reduces the training frequency when there are
+ adaptive_training: bool = False
+ Whether to use adapative training, which reduces the training frequency when there are
Review Comment:
:facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] octoJon commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
octoJon commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r891549020
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Review Comment:
Oh, shoot, but the parameter name itself actually has the extra 'a'... Well, sorry for what I thought was just a comment fix which now looks like it fixing spelling within the code.
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Review Comment:
Oh, shoot, but the parameter name itself actually has the extra 'a'... Well, sorry for what I thought was just a comment fix which now looks like it requires fixing spelling within the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] octoJon commented on a diff in pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
octoJon commented on code in PR #11608:
URL: https://github.com/apache/tvm/pull/11608#discussion_r891546887
##########
python/tvm/auto_scheduler/cost_model/xgb_model.py:
##########
@@ -99,7 +99,7 @@ class XGBModel(PythonBasedModel):
model_file: Optional[str]
If is not None, save model to this file after every update.
adapative_training: bool = False
Review Comment:
Looks like this one is also 'adapative' instead of 'adaptive'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] comaniac merged pull request #11608: [python][docs] fix docstring typo
Posted by GitBox <gi...@apache.org>.
comaniac merged PR #11608:
URL: https://github.com/apache/tvm/pull/11608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org