You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "kindomLee (via GitHub)" <gi...@apache.org> on 2023/06/12 06:39:24 UTC
[GitHub] [apisix] kindomLee commented on a diff in pull request #9622: fix: add missing config in google cloud logging plugin
kindomLee commented on code in PR #9622:
URL: https://github.com/apache/apisix/pull/9622#discussion_r1226156128
##########
apisix/plugins/google-cloud-logging.lua:
##########
@@ -62,7 +63,7 @@ local schema = {
default = "https://logging.googleapis.com/v2/entries:write"
},
},
- required = { "private_key", "project_id", "token_uri" }
+ required = { "client_email", "private_key", "project_id", "token_uri" }
Review Comment:
From the JWT claim set
https://developers.google.com/identity/protocols/oauth2/service-account?hl=en#authorizingrequests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org