You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 21:56:24 UTC
[GitHub] [superset] AAfghahi commented on a change in pull request #12923: fix: added text and changed margins
AAfghahi commented on a change in pull request #12923:
URL: https://github.com/apache/superset/pull/12923#discussion_r569777858
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -220,7 +220,7 @@
);
// ** `.form-group` margin
-@form-group-margin-bottom: 16px;
+@form-group-margin-bottom: 8px;
Review comment:
Hello, I was also uncomfortable changing this, since it is a global change. In the ticket, Stephen mentioned that he wanted the change for all form groups. So I thought that it might be for everything. Relooking at it, he might have meant for all of the form groups on this page however.
Will go back and change it using emotion styles instead. It will be a good opportunity to work with emotion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org