You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 14:26:11 UTC

[GitHub] [arrow] pitrou edited a comment on pull request #10579: ARROW-11932: [C++] Implement ArrayBuilder::AppendScalar

pitrou edited a comment on pull request #10579:
URL: https://github.com/apache/arrow/pull/10579#issuecomment-869731284


   Hmm, it looks like the implementation could be more optimized. When appending multiple scalars (or multiple times the same scalars), the required space could be reserved. Also, at least for primitive types, I would expect appending multiple scalars to be much more streamlined than this.
   
   (it looks like such optimizations could be crafted more easily if `AppendScalar` was a bunch of virtual methods?)
   
   Perhaps create a TODO JIRA for those optimizations, unless you would like to work on them on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org