You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/19 14:23:01 UTC

[GitHub] [shardingsphere] sandynz commented on a change in pull request #10121: Report execution process from one proxy for running SQLs by RQL

sandynz commented on a change in pull request #10121:
URL: https://github.com/apache/shardingsphere/pull/10121#discussion_r615893420



##########
File path: shardingsphere-infra/shardingsphere-infra-executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/spi/ExecuteProcessReporter.java
##########
@@ -31,9 +31,8 @@
      * Report the summary of this task.
      * @param context context
      * @param executionGroupContext execution group context
-     * @param constants constants
      */
-    void report(SQLStatementContext<?> context, ExecutionGroupContext<? extends SQLExecutionUnit> executionGroupContext, ExecuteProcessConstants constants);
+    void report(SQLStatementContext<?> context, ExecutionGroupContext<? extends SQLExecutionUnit> executionGroupContext);

Review comment:
       Currently, `ExecutionGroupContext` constructor just use `ExecuteProcessConstants.EXECUTE_STATUS_START` to construct `ExecuteProcessUnit`.
   I'll update it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org