You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/05 22:05:40 UTC
[GitHub] [pulsar] addisonj opened a new pull request #6486: [proxy] Fix
proxy routing to functions worker
addisonj opened a new pull request #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486
### Motivation
Currently, the proxy only works to proxy v1/v2 functions routes to the
function worker.
### Modifications
This changes this code to proxy all routes for the function worker when
those routes match. At the moment this is still a static list of
prefixes, but in the future it may be possible to have this list of
prefixes be dynamically fetched from the REST routes.
### Verifying this change
- added some tests to ensure the routing works as expected
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature?no
- If yes, how is the feature documented? n/a
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #6486: [proxy] Fix proxy
routing to functions worker
Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-595832091
oh yep, missed that one as it isn't part of the v3 group
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie merged pull request #6486: [proxy] Fix proxy routing
to functions worker
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6486: [proxy] Fix proxy
routing to functions worker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-598574926
cherry-picked into branch-2.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #6486: [proxy] Fix proxy
routing to functions worker
Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-595524720
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] addisonj commented on issue #6486: [proxy] Fix proxy
routing to functions worker
Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-595872311
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Lanayx commented on issue #6486: [proxy] Fix proxy routing
to functions worker
Posted by GitBox <gi...@apache.org>.
Lanayx commented on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-595729346
Shouldn't `admin/v2/worker` and `admin/v3/worker` routes be redirected to worker as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] Lanayx edited a comment on issue #6486: [proxy] Fix proxy
routing to functions worker
Posted by GitBox <gi...@apache.org>.
Lanayx edited a comment on issue #6486: [proxy] Fix proxy routing to functions worker
URL: https://github.com/apache/pulsar/pull/6486#issuecomment-595729346
Shouldn't `admin/worker`, `admin/v2/worker` and `admin/v3/worker` routes be redirected to worker as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services