You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/06 02:29:02 UTC
[GitHub] [pulsar] Jennifer88huang opened a new pull request #7767: [WIP][Issue 5157][docs] Update source and sink --processing-guarantees description
Jennifer88huang opened a new pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767
Fixes #5157
### Motivation
The description for source and sink `--processing-guarantees` is not clear.
### Modifications
Update related description for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #7767: [WIP][Issue 5157][docs] Update source and sink --processing-guarantees description
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767#discussion_r466193650
##########
File path: site2/docs/io-cli.md
##########
@@ -263,7 +263,7 @@ $ pulsar-admin sources localrun options
|`--name`|The source’s name.|
|`--namespace`|The source’s namespace.|
|`--parallelism`|The source’s parallelism factor, that is, the number of source instances to run).|
-|`--processing-guarantees`|The processing guarantees (aka delivery semantics) applied to the source. <br>Available values: ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
+|`--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is use to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
Review comment:
```suggestion
|`--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is used to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #7767: [WIP][Issue 5157][docs] Update source and sink --processing-guarantees description
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767#discussion_r466192895
##########
File path: site2/docs/io-cli.md
##########
@@ -64,7 +64,7 @@ $ pulsar-admin sources create options
|`--name` | The source's name.
| `--namespace` | The source's namespace.
| ` --parallelism` | The source's parallelism factor, that is, the number of source instances to run.
-| `--processing-guarantees` | The processing guarantees (aka delivery semantics) applied to the source.<br>Possible Values: ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
+| `--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is use to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
Review comment:
```suggestion
| `--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is used to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang merged pull request #7767: [Issue 5157][docs] Update source and sink --processing-guarantees description
Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #7767: [WIP][Issue 5157][docs] Update source and sink --processing-guarantees description
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767#discussion_r466193418
##########
File path: site2/docs/io-cli.md
##########
@@ -95,7 +95,7 @@ $ pulsar-admin sources update options
|`--name` | The source's name.
| `--namespace` | The source's namespace.
| ` --parallelism` | The source's parallelism factor, that is, the number of source instances to run.
-| `--processing-guarantees` | The processing guarantees (aka delivery semantics) applied to the source.<br>Possible Values: ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
+| `--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is use to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
Review comment:
```suggestion
| `--processing-guarantees` | The processing guarantees (also named as delivery semantics) applied to the source. A source connector receives messages from external system and writes messages to a Pulsar topic. The `--processing-guarantees` is used to ensure the processing guarantees for writing messages to the Pulsar topic. <br>The available values are ATLEAST_ONCE, ATMOST_ONCE, EFFECTIVELY_ONCE.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #7767: [WIP][Issue 5157][docs] Update source and sink --processing-guarantees description
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #7767:
URL: https://github.com/apache/pulsar/pull/7767#issuecomment-670350223
@sijia-w thanks for your advice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org