You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 21:32:38 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2294: Move some logical plan types to `datafusion-expr` crate

alamb commented on code in PR #2294:
URL: https://github.com/apache/arrow-datafusion/pull/2294#discussion_r854571152


##########
datafusion/expr/src/logical_plan/mod.rs:
##########
@@ -0,0 +1,23 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   I wonder if making this a separate crate like `datafusion-logical-plan` might be considered? Is there any reason the logical plan structs need to be in the expr? I could (potentially) see a use of just `Expr`s without also `LogicalPlan`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org