You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 06:39:18 UTC

[GitHub] [flink] Myasuka opened a new pull request #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Myasuka opened a new pull request #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920
 
 
   
   ## What is the purpose of the change
   
   Turn on `state.backend.rocksdb.memory.managed` to enable memory limit on RocksDB
   
   ## Brief change log
   
     - Turn on `state.backend.rocksdb.memory.managed` to enable memory limit
     - Avoid `MemoryManagerBuilder` to reserve `HEAP` memory to align with current design that memory manager only cover `OFF-HEAP` memory (see [FLINK-15023](https://issues.apache.org/jira/browse/FLINK-15023))
   
   
   ## Verifying this change
   
   This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577032640
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 03e3e7d2121991542b5107995ea2d396065e499a (Wed Jan 22 06:42:16 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann closed pull request #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556916 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:ff331a3761e107f8d515016f253b5424b74fc453 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145611464 TriggerType:PUSH TriggerID:ff331a3761e107f8d515016f253b5424b74fc453
   Hash:ff331a3761e107f8d515016f253b5424b74fc453 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4563 TriggerType:PUSH TriggerID:ff331a3761e107f8d515016f253b5424b74fc453
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550) 
   * ff331a3761e107f8d515016f253b5424b74fc453 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145611464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4563) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556916 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:ff331a3761e107f8d515016f253b5424b74fc453 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:ff331a3761e107f8d515016f253b5424b74fc453
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550) 
   * ff331a3761e107f8d515016f253b5424b74fc453 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145556916 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145556916) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556916 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:ff331a3761e107f8d515016f253b5424b74fc453 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145611464 TriggerType:PUSH TriggerID:ff331a3761e107f8d515016f253b5424b74fc453
   Hash:ff331a3761e107f8d515016f253b5424b74fc453 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4563 TriggerType:PUSH TriggerID:ff331a3761e107f8d515016f253b5424b74fc453
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550) 
   * ff331a3761e107f8d515016f253b5424b74fc453 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145611464) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4563) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577180011
 
 
   <!--
   Meta data
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145556916 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   Hash:a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550 TriggerType:PUSH TriggerID:a15d171fbc44ff970a3bd056c28dd2ac5188ea68
   -->
   ## CI report:
   
   * a15d171fbc44ff970a3bd056c28dd2ac5188ea68 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145556916) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4550) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] tillrohrmann commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10920: [FLINK-15692][state backend] Enable limiting RocksDB memory consumption by default
URL: https://github.com/apache/flink/pull/10920#issuecomment-577679710
 
 
   Manually merged via b7ddcee175acaaefc9341079439b9a0c8a63ec46

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services